Skip to content

Add separator before Bugzilla comment footer #6550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ayoubdiourin7 wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −3
Open

Add separator before Bugzilla comment footer #6550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/hackbot-runtime/hackbot_runtime/actions/bugzilla.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ async def add_comment(
Use is_private=true for security-sensitive notes. Recorded into the run
summary for human review — does not post to Bugzilla.
"""
text_with_footer = text.rstrip() + "\n\n" + _COMMENT_FOOTER
text_with_footer = text.rstrip() + "\n\n---\n\n" + _COMMENT_FOOTER
recorder.record(
"bugzilla.add_comment",
{"bug_id": bug_id, "text": text_with_footer, "is_private": is_private},
Expand Down
3 changes: 1 addition & 2 deletions libs/hackbot-runtime/tests/test_bugzilla_actions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ async def test_add_comment_appends_footer():
rec = ActionsRecorder()
await bugzilla.add_comment(rec, bug_id=1, text="Looks invalid.", reasoning="r")
text = rec.actions[0]["params"]["text"]
assert text.startswith("Looks invalid.")
assert text.endswith(bugzilla._COMMENT_FOOTER)
assert text == "Looks invalid.\n\n---\n\n" + bugzilla._COMMENT_FOOTER
assert rec.actions[0]["params"]["is_private"] is False


Expand Down