Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Standalone web sessions are incorrectly labeled as OAuth clients.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds visual service-type badges to the admin panel’s Connected Services cards.
Changes:
- Labels services as devices or OAuth clients with color-coded badges.
- Adds tests for both labels.
File summaries
| File | Description |
|---|---|
ConnectedServices/index.tsx |
Renders service-type badges. |
ConnectedServices/index.test.tsx |
Tests device and OAuth labels. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
## Because - The admin panel Connected Services list labeled every row without a device ID as an OAuth client. - A standalone web session has no client ID. The list gave it the wrong label. ## This pull request - Adds a `serviceKind` helper in `ConnectedServices/index.tsx`. The helper returns the badge label and the badge color. - Labels a row with a device ID "Device", a row with a client ID "OAuth client", and every other row "Web session". - Adds tests in `index.test.tsx` for the three labels and for a row that has both IDs. ## Issue that this pull request solves Closes: https://mozilla-hub.atlassian.net/browse/FXA-14578
clouserw
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Because
This pull request
serviceKindhelper inConnectedServices/index.tsx. The helper returns the badge label and the badge color.index.test.tsxfor the three labels and for a row that has both IDs.Issue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-14578
Checklist
Put an
xin the boxes that applyHow to review (Optional)
ConnectedServices/index.tsx, theserviceKindhelper.index.test.tsx.Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
npx nx lint fxa-admin-panel: exit 0.tsc --noEmit: clean.