Conversation
Because: - The pairing QR card is one of several promos a sync sign-in can land on, and the only ways off it were to pair or to leave the site. - Users who open "add a device" themselves can change their mind and need the same exit. This commit: - Adds a "Skip for now" button below the QR card on /pair/authority/scan_qr that closes the pairing channel and goes to /settings. - Adds the dtm_desktop.qr_skip Glean event and records it on skip. - Renders the card from the page itself so the button can sit under it. - Covers the button, channel teardown, navigation and metric in the page, container and Glean tests. Closes #FXA-14523
dschom
marked this pull request as ready for review
September 18, 2026 23:55
vbudhram
approved these changes
Sep 21, 2026
| return <ScanQR {...{ qrCodeValue }} />; | ||
| const onSkip = () => { | ||
| GleanMetrics.dtmDesktop.qrSkip(); | ||
| // Skipping ends the flow, so the channel goes with it. `destroy()` drops |
| description: The value proposition experiment branch shown to the user | ||
| type: string | ||
|
|
||
| dtm_desktop: |
bcolsson
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
dtm_desktopGlean event on that exit.This pull request
/pair/authority/scan_qrthat closes the pairing channel and navigates to/settings.dtm_desktop.qr_skipGlean event and records it on skip.Issue that this pull request solves
Closes: FXA-14523
Checklist
Put an
xin the boxes that applyHow to review (Optional)
ScanQR/container.tsx(skip handler),ScanQR/index.tsx(card rendered outsideAppLayout)web/index.ts→lib/glean/index.ts→ScanQR/*Screenshots (Optional)
FXA-14523 — "Skip for now" below the QR card (Storybook,
Pages/Pair2/Authority/ScanQR/Default)Other information (Optional)
dtm_desktop.QR_skip; Glean requires lowercase snake_case, so it isdtm_desktop.qr_skip.scan_qrpage is the only v2 screen that shows a QR code, so it is the only one changed.