Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #586.
When the inputs contain
.gcdafiles but no.gcnofiles (e.g. afterfind . -name "*.gc*" -deletewiped the compile-time notes), grcov panicked with the genericNo input files found. It now reports:The existing message is kept when there are no input files at all.
Test: tightened the existing
test_zip_producer_with_gcda_archive_and_no_gcno_archiveto#[should_panic(expected = "found .gcda files without .gcno files")]. It fails onmain(panic has the old message) and passes with this change.Validation (local, rustc 1.98.1):
cargo test --lib: 137 passed. 4llvm_tools::tests::*fail becausellvm-profdataisn't installed on my machine. They fail the same way on unmodifiedmain.cargo fmt --check: cleancargo clippy --lib --tests: no warnings