Repository navigation
Compute operator bounding boxes in the worker - #22289
calixteman wants to merge 3 commits into
Conversation
Viewer previewCommit e92cb3b (build logs).
Previews are removed when the PR closes and may be pruned after 30 days without an update. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22289 +/- ##
==========================================
+ Coverage 90.52% 90.64% +0.11%
==========================================
Files 278 280 +2
Lines 68586 68764 +178
==========================================
+ Hits 62090 62331 +241
+ Misses 6496 6433 -63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will improve performance by 13.42%
Performance Changes
Tip Curious why performance improved? Comment Comparing Footnotes
|
343cf11 to
3207050
Compare
3207050 to
932615e
Compare
932615e to
6f38415
Compare
Snuffleupagus
left a comment
There was a problem hiding this comment.
It looks like this made Util.multiplyByDOMMatrix unused, so that can probably be removed now?
6f38415 to
99ccb6b
Compare
99ccb6b to
34f4838
Compare
Propagate bounds to operator dependencies and send packed boxes with the final operator-list chunk. Expose them through OperatorBBoxes.
Migrate operation filters and debugger highlights to worker bounds. Remove display-side bounding-box tracking and recordOperations.
34f4838 to
e92cb3b
Compare
Compute operator bounds and propagate them to dependencies in the worker. Send packed bounds to the display layer for partial rendering and debugger highlights.
Remove display-side bounding-box tracking and recordOperations, and enable optimized partial rendering by default.