Repository navigation
Avoid using a null edit toolbar when the editor is removed while it's being built (issue 22341) - #22362
Open
cestercian wants to merge 1 commit into
Open
Avoid using a null edit toolbar when the editor is removed while it's being built (issue 22341)#22362cestercian wants to merge 1 commit into
cestercian wants to merge 1 commit into
Conversation
… being built (issue 22341)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addEditToolbarawaitsthis._editToolbar.addButton(...), and if the editor gets removed in the meantime (e.g.delete()while a FreeText editor is still being edited)_editToolbaris null when it resumes, so it throwsCannot read properties of null (reading 'addButton').Now the toolbar is kept in a local and we bail out if
_editToolbarisn't that instance anymore after the await. Added an integration test that deletes a FreeText editor mid-edit and checks there's no error, then undoes and checks there's a single toolbar.Fixes #22341