Skip to content

Use TypedArray.prototype.set in the _makeWrapper PostScript wasm-code #22379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Snuffleupagus wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use TypedArray.prototype.set in the _makeWrapper PostScript wasm-code #22379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 5 additions & 42 deletions src/core/postscript/wasm_compiler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -977,61 +977,24 @@ function _makeWrapper(exports, nIn, nOut) {
const { fn, mem } = exports;
const outView = new Float64Array(mem.buffer, 0, nOut);

// Unrolled for common arities (1-4) to avoid loop overhead.
let writeOut;
switch (nOut) {
case 1:
writeOut = (dest, destOffset) => {
dest[destOffset] = outView[0];
};
break;
case 2:
writeOut = (dest, destOffset) => {
dest[destOffset] = outView[0];
dest[destOffset + 1] = outView[1];
};
break;
case 3:
writeOut = (dest, destOffset) => {
dest[destOffset] = outView[0];
dest[destOffset + 1] = outView[1];
dest[destOffset + 2] = outView[2];
};
break;
case 4:
writeOut = (dest, destOffset) => {
dest[destOffset] = outView[0];
dest[destOffset + 1] = outView[1];
dest[destOffset + 2] = outView[2];
dest[destOffset + 3] = outView[3];
};
break;
default:
writeOut = (dest, destOffset) => {
for (let i = 0; i < nOut; i++) {
dest[destOffset + i] = outView[i];
}
};
}

// Specialize the call site for each arity so that the engine sees a
// fixed-argument call rather than a spread — avoiding the per-call
// argument-array allocation that `fn(...inBuf)` would cause.
switch (nIn) {
case 1:
return (src, srcOffset, dest, destOffset) => {
fn(src[srcOffset]);
writeOut(dest, destOffset);
dest.set(outView, destOffset);
};
case 2:
return (src, srcOffset, dest, destOffset) => {
fn(src[srcOffset], src[srcOffset + 1]);
writeOut(dest, destOffset);
dest.set(outView, destOffset);
};
case 3:
return (src, srcOffset, dest, destOffset) => {
fn(src[srcOffset], src[srcOffset + 1], src[srcOffset + 2]);
writeOut(dest, destOffset);
dest.set(outView, destOffset);
};
case 4:
return (src, srcOffset, dest, destOffset) => {
Expand All @@ -1041,7 +1004,7 @@ function _makeWrapper(exports, nIn, nOut) {
src[srcOffset + 2],
src[srcOffset + 3]
);
writeOut(dest, destOffset);
dest.set(outView, destOffset);
};
default: {
// Fallback for unusual arities: pre-allocate once, copy per call.
Expand All @@ -1051,7 +1014,7 @@ function _makeWrapper(exports, nIn, nOut) {
inBuf[i] = src[srcOffset + i];
}
fn(...inBuf);
writeOut(dest, destOffset);
dest.set(outView, destOffset);
};
}
}
Expand Down
Loading