Skip to content

Prevent errors when extracting textContent with zero initial font size (issue 22381) - #22384

Merged
Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:issue-22381
Oct 29, 2026
Merged

Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:issue-22381

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for f6ad3fa (run, references from mozilla/pdf.js.refs@4694e71d21).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ✅ 1413 13m 6s 0 0 0 0
Windows ✅ 1413 15m 25s 0 0 0 0

The report is kept for 30 days and replaced by the next run.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 29, 2026
@codecov-commenter

codecov-commenter commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.58%. Comparing base (e226742) to head (437bce6).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22384      +/-   ##
==========================================
- Coverage   90.59%   90.58%   -0.01%     
==========================================
  Files         278      278              
  Lines       68558    68558              
==========================================
- Hits        62108    62102       -6     
- Misses       6450     6456       +6     
Flag Coverage Δ
browsertest 66.27% <ø> (-0.02%) ⬇️
fonttest 8.99% <ø> (ø)
integrationtest 69.53% <ø> (-0.02%) ⬇️
unittest 61.25% <ø> (-0.01%) ⬇️
unittestcli 59.00% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed

codspeed Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 88 untouched benchmarks
⏩ 174 skipped benchmarks1


Comparing Snuffleupagus:issue-22381 (437bce6) with master (87b369c)

Open in CodSpeed

Footnotes

  1. 174 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 29, 2026
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 29, 2026

@calixteman calixteman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getTextContent drops all page text ("Cannot read properties of null (reading 'name')") when the first text in a stream has font size 0

3 participants