Skip to content

Regenerate button appearances for NeedAppearances (bug 2084610) - #22386

Merged
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:bug2084610
Oct 31, 2026
Merged

calixteman merged 1 commit into
mozilla:masterfrom
calixteman:bug2084610

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

Rebuild checkbox and radio appearances from /MK and /DA rather than using the existing streams. This fixes the /MK /CA star in the test PDF. Preserve /MK entries on save so custom marks survive reloading.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for 4129873 (run, references from mozilla/pdf.js.refs@4694e71d21).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ⚠️ 1414 13m 51s 0 11 0 1 view differences
Windows ⚠️ 1414 15m 32s 0 10 0 1 view differences

The report is kept for 30 days and replaced by the next run.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

@codecov-commenter

codecov-commenter commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.58%. Comparing base (743102c) to head (079921e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22386      +/-   ##
==========================================
- Coverage   90.58%   90.58%   -0.01%     
==========================================
  Files         278      278              
  Lines       68573    68585      +12     
==========================================
+ Hits        62117    62127      +10     
- Misses       6456     6458       +2     
Flag Coverage Δ
browsertest 66.27% <90.62%> (-0.02%) ⬇️
fonttest 8.99% <ø> (ø)
integrationtest 69.59% <95.31%> (+0.04%) ⬆️
unittest 61.26% <100.00%> (+<0.01%) ⬆️
unittestcli 59.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 29, 2026
@codspeed

codspeed Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 86 untouched benchmarks
⏩ 174 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ PDFPageProxy.render: luminosity soft mask (issue18956.pdf) 20.4 ms 22.7 ms -10.4%
⚡ Lexer.getObj: paths (bug1743245.pdf) 26.5 ms 23.5 ms +12.71%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing calixteman:bug2084610 (079921e) with master (743102c)

Open in CodSpeed

Footnotes

  1. 174 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@timvandermeij timvandermeij left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comments addressed. Looks good!

Comment thread test/unit/annotation_spec.js Resolved
Comment thread test/unit/annotation_spec.js Resolved
Comment thread src/core/annotation.js Resolved
Comment thread src/core/annotation.js Resolved
Comment thread test/test_manifest.json Resolved
Rebuild checkbox and radio appearances from /MK and /DA rather than
using the existing streams. This fixes the /MK /CA star in the test PDF.
Preserve /MK entries on save so custom marks survive reloading.
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 30, 2026
@calixteman
calixteman merged commit 5b02155 into mozilla:master Oct 31, 2026
23 of 24 checks passed
@calixteman
calixteman deleted the bug2084610 branch October 31, 2026 12:57
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants