Skip to content

Handle truncated RGB data in convertRGBToRGBA - #22402

Merged
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:truncated-rgb-image-data
Oct 31, 2026
Merged

calixteman merged 1 commit into
mozilla:masterfrom
calixteman:truncated-rgb-image-data

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

Bound 32-bit reads to the source view to avoid RangeError and reading unrelated bytes. The scalar loops treat missing RGB bytes as zeros.

Bound 32-bit reads to the source view to avoid RangeError and reading unrelated bytes. The scalar loops treat missing RGB bytes as zeros.
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 30, 2026
@codecov-commenter

codecov-commenter commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.58%. Comparing base (aa89148) to head (7924e33).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22402      +/-   ##
==========================================
- Coverage   90.58%   90.58%   -0.01%     
==========================================
  Files         278      278              
  Lines       68568    68568              
==========================================
- Hits        62115    62112       -3     
- Misses       6453     6456       +3     
Flag Coverage Δ
browsertest 66.29% <100.00%> (ø)
fonttest 8.99% <0.00%> (ø)
integrationtest 69.54% <100.00%> (-0.01%) ⬇️
unittest 61.26% <100.00%> (-0.01%) ⬇️
unittestcli 59.02% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed

codspeed Bot commented Oct 30, 2026

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 86 untouched benchmarks
⏩ 174 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ PredictorStream: PNG xref streams (issue20513.pdf) 400.9 µs 449 µs -10.71%
⚡ PartialEvaluator.buildPath: lines (bug1743245.pdf) 19.2 ms 17 ms +13.21%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing calixteman:truncated-rgb-image-data (7924e33) with master (22f5df1)2

Open in CodSpeed

Footnotes

  1. 174 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on master (aa89148) during the generation of this report, so 22f5df1 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for 7924e33 (run, references from mozilla/pdf.js.refs@c5cf6c9ab0).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ✅ 1413 12m 42s 0 0 0 0
Windows ⚠️ 1413 14m 28s 0 1 0 0 view differences

The report is kept for 30 days and replaced by the next run.

@timvandermeij timvandermeij left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing browser tests. Thanks!

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 30, 2026
@calixteman
calixteman merged commit b1b2849 into mozilla:master Oct 31, 2026
31 of 32 checks passed
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 31, 2026
@calixteman
calixteman deleted the truncated-rgb-image-data branch October 31, 2026 15:37

This branch was successfully deployed

1 active deployment
sync_pdfs — 7924e33a Deployed Oct 30, 2026 by timvandermeij via request #682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants