Skip to content

Inline the AnnotationLayerBuilder.prototype.#initAnnotationLayer method - #22409

Merged
Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:initAnnotationLayer-inline
Oct 31, 2026
Merged

Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:initAnnotationLayer-inline

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

That method was added in PR #19110, however after PR #20321 it's only invoked once and the code can thus be inlined again.

…thod

That method was added in PR 19110, however after PR 20321 it's only invoked once and the code can thus be inlined again.
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 31, 2026
@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

@codecov-commenter

codecov-commenter commented Oct 31, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.57%. Comparing base (743102c) to head (4ef78fe).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22409      +/-   ##
==========================================
- Coverage   90.58%   90.57%   -0.02%     
==========================================
  Files         278      278              
  Lines       68573    68572       -1     
==========================================
- Hits        62117    62108       -9     
- Misses       6456     6464       +8     
Flag Coverage Δ
browsertest 66.27% <0.00%> (-0.02%) ⬇️
integrationtest 69.53% <100.00%> (-0.02%) ⬇️
unittest 61.26% <0.00%> (+<0.01%) ⬆️
unittestcli 59.02% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed

codspeed Bot commented Oct 31, 2026

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 86 untouched benchmarks
⏩ 174 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ Pattern.parseShading: tensor-product patch mesh (personwithdog.pdf) 36.9 ms 42.3 ms -12.8%
⚡ PartialEvaluator.buildPath: lines (bug1743245.pdf) 19.6 ms 17 ms +15.69%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing Snuffleupagus:initAnnotationLayer-inline (4ef78fe) with master (743102c)

Open in CodSpeed

Footnotes

  1. 174 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@calixteman calixteman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus
Snuffleupagus merged commit ab3819f into mozilla:master Oct 31, 2026
23 of 24 checks passed
@Snuffleupagus
Snuffleupagus deleted the initAnnotationLayer-inline branch October 31, 2026 17:08
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants