Skip to content

Add a WasmLoader class to load Wasm modules or their JS fallbacks - #22420

Merged
calixteman merged 2 commits into
mozilla:masterfrom
calixteman:wasm_loader
Nov 2, 2026
Merged

calixteman merged 2 commits into
mozilla:masterfrom
calixteman:wasm_loader

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Nov 2, 2026
@codecov-commenter

codecov-commenter commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.59%. Comparing base (f70fabb) to head (cef39e5).

Files with missing lines Patch % Lines
src/core/wasm_loader.js 90.32% 3 Missing ⚠️
src/core/wasm_image.js 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22420      +/-   ##
==========================================
+ Coverage   90.52%   90.59%   +0.06%     
==========================================
  Files         278      279       +1     
  Lines       68586    68595       +9     
==========================================
+ Hits        62090    62145      +55     
+ Misses       6496     6450      -46     
Flag Coverage Δ
browsertest 66.26% <71.05%> (+0.04%) ⬆️
fonttest 8.97% <5.26%> (-0.02%) ⬇️
integrationtest 69.60% <50.00%> (+<0.01%) ⬆️
unittest 61.27% <65.78%> (+0.02%) ⬆️
unittestcli 59.03% <86.84%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed

codspeed Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 85 untouched benchmarks
⏩ 174 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ Ascii85Stream (bug1337429.pdf) 3.7 ms 4.2 ms -12.33%
⚡ Pattern.parseShading: radial (radial_gradients.pdf) 7.1 ms 6.2 ms +13.14%
⚡ Lexer: tokenize content stream 14.5 ms 13 ms +11.83%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing calixteman:wasm_loader (cef39e5) with master (f70fabb)

Open in CodSpeed

Footnotes

  1. 174 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for cef39e5 (run, references from mozilla/pdf.js.refs@d16403bcaa).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ✅ 1414 12m 4s 0 0 0 0
Windows ✅ 1414 15m 21s 0 0 0 0

The report is kept for 30 days and replaced by the next run.

Comment thread src/core/wasm_loader.js Resolved
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Nov 2, 2026
In Node.js, resolve relative JS fallback paths from the working directory.
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Nov 2, 2026
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Nov 2, 2026

@Snuffleupagus Snuffleupagus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thanks.

@calixteman
calixteman merged commit a4e6780 into mozilla:master Nov 2, 2026
27 of 28 checks passed
@calixteman
calixteman deleted the wasm_loader branch November 2, 2026 19:37
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Nov 2, 2026

This branch was successfully deployed

1 active deployment
sync_pdfs — cef39e54 Deployed Nov 2, 2026 by Snuffleupagus via request #692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants