Repository navigation
Keep only the Fission JetStream 3 signature per platform - #3
Merged
Merged
Conversation
The script kept every jetstream3 signature, so the A55 fenix rows mixed Fission and non-Fission runs. Keep one signature per application/platform/test: prefer Fission, then the fewest extra_options (skipping profiling runs), then the newest. This matches the dashboard chart (selectCanonicalSignatures in mozilla/performance).
Author
|
(cc @mgaudet ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
presently, JS3 chart data is no-fission, but the JS3 table is mixed of fission and no-fission. https://performance.mozilla.org/jetstream?os=android-a55
once mozilla/performance#76 is merged, then JS3 chart data will be fission, but the table will still be mixed.
This PR changes the script so that the table only uses fission android data instead of mixing it.
Also, I ran the patched script locally and compared its output with the
current jetstream-data.json.gz:
Fission series is unchanged (median 71.69).
have Fission runs.
a single Safari point on macosx1470 (old Intel Mac, no longer on the
dashboard).