Conversation
nodchip
reviewed
Sep 12, 2026
| class Solution: | ||
| def subarraySum(self, nums: List[int], k: int) -> int: | ||
| count = 0 | ||
| cumulative_sums = {0:1} |
There was a problem hiding this comment.
: のあとにスペースを空けることをお勧めいたします。
参考までにスタイルガイドへのリンクを共有いたします。
https://google.github.io/styleguide/pyguide.html#36-whitespace
Do use whitespace after a comma, semicolon, or colon, except at the end of the line.
なお、このスタイルガイドは“唯一の正解”というわけではなく、数あるガイドラインの一つに過ぎません。チームによって重視される書き方や慣習も異なります。そのため、ご自身の中に基準を持ちつつも、最終的にはチームの一般的な書き方に合わせることをお勧めします。
| return count | ||
| ``` | ||
|
|
||
| これだとタイムアウトした。 |
There was a problem hiding this comment.
1 <= nums.length <= 2 * 104 であり、 dict が CPython でハッシュテーブルで実装されていることを考えると、タイムアウトすることは考えられないと思います。実際、 LeetCode に投げたところ、 28 ms でした。
Yuto729/leetcode#16
に従い、処理時間を見積もってみることをお勧めいたします。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/subarray-sum-equals-k/description/