Repository navigation
Make Eigen an optional dependency - #27
Merged
Merged
Conversation
balsa::geometry is zipper-only: drop the Eigen overloads from get_angle, winding_number, curves/volume, bounding_box, earclipping, simplex volume/circumcenter/point_in_circumcircle, uniformly_sample_simplex and simplicial_complex/boundaries. Eigen callers can convert via balsa/eigen/zipper_compat.hpp. balsa/eigen/* headers are still shipped. eigen3 is optional (required: false) and only used by core/tests/eigen, which builds when Eigen is found. test_winding_number ported to zipper types.
mtao
force-pushed
the
refactor/remove-eigen
branch
from
October 26, 2026 01:56
58c013f to
54655b5
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eigen is no longer a dependency of balsa's libraries.
balsa::geometry(get_angle, winding_number, curves/volume, bounding_box, earclipping, simplex volume/circumcenter/point_in_circumcircle, uniformly_sample_simplex, simplicial_complex/boundaries). The zipper overloads remain; Eigen callers can usebalsa::eigen::as_zipper/as_eigenfromzipper_compat.hpp.balsa/eigen/*headers (incl.zipper_compat.hpp) are still shipped.eigen3is looked up withrequired: falseand only used bycore/tests/eigen(incl.test_zipper_compat), which builds when Eigen is found.test_winding_numberported from Eigen to zipper types.Tested: full build + 11/11 tests pass.