Accept CMS OCTET STRING encoding for SpcIndirectDataContent - #506
Merged
Merged
Conversation
olszomal
force-pushed
the
fix-cms-octet-string
branch
from
September 23, 2026 12:54
3d0821a to
9593bb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related Issue
Fixes #505
Current Behavior
SpcIndirectDataContentdecoding accepts only ASN.1 SEQUENCE values.New Behavior
Accept both directly encoded ASN.1 SEQUENCE content and CMS OCTET STRING-wrapped content, as described in RFC 5652 section 5.2.1.
Scope of Changes
Update
asn1_type_get_indirect_data_content()to handle both PKCS#7 and CMS representations.Testing
Additional Notes
License Declaration