[ISSUE #10660]✨Include the error detail in the pull request exception log

[WaterWhisperer]

Which Issue(s) This PR Fixes(Closes)

• Fixes [Enhancement✨] Include the error detail in the pull request exception log #10660

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

• Bug Fixes
  • Improved pull exception logging by including the broker response code alongside the consumer group and error details.

[rocketmq-rust-bot]

🔊@WaterWhisperer 🚀Thanks for your contribution🎉！

💡CodeRabbit(AI) will review your code first🔥！

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: a3328978-8e29-4632-b663-59d539cc3ddb

📥 Commits

Reviewing files that changed from the base of the PR and between 28c7a3b and 63f8d68.

📒 Files selected for processing (1)

• rocketmq-client/src/consumer/pull_callback.rs

Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.

---

Walkthrough

The generic pull exception warning now logs the broker response code and error alongside the consumer group. Retry timing and exception control flow remain unchanged.

Changes

Pull exception logging

Layer / File(s)	Summary
Expand pull exception warning rocketmq-client/src/consumer/pull_callback.rs	The warning includes the broker response code and error for non-retry-topic pull exceptions.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: mxsm

Merge Risk: ⚪ Minimal · up to 63f8d

The warning adds useful broker and error details without changing pull handling or retry behavior.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: adding error details to the pull request exception log. It is specific and related to the changeset.
Linked Issues check	✅ Passed	The change satisfies issue #10660. In rocketmq-client/src/consumer/pull_callback.rs, the generic warn! now includes broker_code={:?} and error={}. It preserves the warn! level and the existi…
Out of Scope Changes check	✅ Passed	The whole pull request changes only the targeted warning in rocketmq-client/src/consumer/pull_callback.rs. The added broker response code and error details directly support issue #10660. No unrelate…

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit logs the broker’s reply,
With error details clear and nigh.
The consumer group stays in view,
While retry paths remain true.
No hopping flow is rearranged,
Just warnings better explained.}

_{Comment @coderabbitai help to get the list of available commands.}