[ISSUE #10659]🐛PopReviveService writes a skip-commit diagnostic to stdout

[WaterWhisperer]

Which Issue(s) This PR Fixes(Closes)

• Fixes [Bug🐛] PopReviveService writes a skip-commit diagnostic to stdout #10659

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

• Bug Fixes
  • Improved logging when revive commits are skipped, including the related topic and queue details for easier troubleshooting.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 1ba973bf-302c-4bf8-8633-f97c2d952de0

📥 Commits

Reviewing files that changed from the base of the PR and between 16df7e8 and aec547f.

📒 Files selected for processing (1)

• rocketmq-broker/src/processor/processor_service/pop_revive_service.rs

Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.

---

Walkthrough

The POP revive skip-commit path now emits a structured warn! event with revive_topic and queue_id instead of writing to stdout.

Changes

POP revive logging

Layer / File(s)	Summary
Structured skip-commit warning rocketmq-broker/src/processor/processor_service/pop_revive_service.rs	Replaces println! with warn! fields for revive_topic and queue_id. The existing return path remains unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: mxsm

Merge Risk: ⚪ Minimal · up to aec54

The change only redirects an existing skip-path diagnostic to structured warning logging, with no established impact on broker behavior.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Linked Issues check	❓ Inconclusive	The diff satisfies the implementation requirements in #10659. It replaces the target println! with warn!, records revive_topic and queue_id as structured fields, preserves the return Ok(()) …	Provide CI or command output that confirms the formatting check, clippy check, broker tests, and the scoped println! check.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the affected component and the stdout diagnostic addressed by the pull request.
Out of Scope Changes check	✅ Passed	The whole-PR diff contains one related change in pop_revive_service.rs. The change directly implements #10659 and does not modify CLI output or test-only println! calls.

Full details: Linked Issues check

Explanation

The diff satisfies the implementation requirements in #10659. It replaces the target println! with warn!, records revive_topic and queue_id as structured fields, preserves the return Ok(()) guard, and leaves the warning message and control flow unchanged. The available evidence does not show results for cargo fmt, cargo clippy, cargo test, or the remaining-println! check.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit spots the warning bright
Structured fields now hop in sight
No stdout trail escapes the stream
Topic and queue join the beam
The skip path keeps its course just right}

_{Comment @coderabbitai help to get the list of available commands.}

[rocketmq-rust-bot]

🔊@WaterWhisperer 🚀Thanks for your contribution🎉！

💡CodeRabbit(AI) will review your code first🔥！

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.