Skip to content

[ISSUE #10829]✨Update cfg-if, syn, and trybuild dependencies - #10830

Merged
mxsm merged 1 commit into
mainfrom
mxsm/issue-10829-dependency-updates
Sep 22, 2026
Merged

mxsm merged 1 commit into
mainfrom
mxsm/issue-10829-dependency-updates

Conversation

@mxsm

@mxsm mxsm commented Sep 22, 2026

Copy link
Copy Markdown
Owner

Which Issue(s) This PR Fixes(Closes)

Brief Description

Update the root Cargo.lock to cfg-if 1.0.5, syn 3.0.6, and trybuild 1.0.121 using targeted local cargo update commands. Update the protocol crate's exact trybuild pin and include its target-triple to target-tuple dependency replacement.

This consolidates the dependency updates proposed in #10811, #10809, and #10489. OpenTelemetry remains deferred, and openraft-rt stays pinned to =0.10.0-alpha.21.

How Did You Test This Change?

Passed locally on Windows with the repository Rust 1.95.0 toolchain:

  • cargo test --locked --target-dir target/dependency-upgrades -p rocketmq-macros: 12 unit tests passed.
  • cargo test --locked --target-dir target/dependency-upgrades -p rocketmq-protocol --test request_header_codec_v3_ui --test request_header_codec_runtime_ui --test remoting_legacy_api_deprecation_ui --test remoting_response_factory_deprecation_ui: all four compiler-diagnostic suites passed.
  • cargo fmt -p rocketmq-protocol -p rocketmq-macros -- --check: passed.
  • git diff --check: passed.

The focused tests ran before fast-forwarding the eight already-merged main commits; those commits do not change the tested packages or dependency manifests. GitHub CI completion is not a merge prerequisite for this PR, as explicitly authorized by the maintainer.

@rocketmq-rust-bot rocketmq-rust-bot added the AI review first Ai review pr first label Sep 22, 2026
@rocketmq-rust-bot

Copy link
Copy Markdown
Collaborator

🔊@mxsm 🚀Thanks for your contribution🎉!

💡CodeRabbit(AI) will review your code first🔥!

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.

@rocketmq-rust-robot rocketmq-rust-robot added enhancement✨ dependencies Pull requests that update a dependency file rust Pull requests that update Rust code approved PR has approved feature🚀 Suggest an idea for this project. labels Sep 22, 2026
@mxsm
mxsm merged commit bd7f7b2 into main Sep 22, 2026
28 of 30 checks passed
@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: mxsm/rocketmq-rust/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: e77538c7-d539-4c2e-92ea-5bfe83335ca2

📥 Commits

Reviewing files that changed from the base of the PR and between dc09f75 and 235d5f9.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • rocketmq-protocol/Cargo.toml
 _________________________________________
< Make it work, make it right, make it 🥕. >
 -----------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI review first Ai review pr first approved PR has approved auto merge dependencies Pull requests that update a dependency file enhancement✨ feature🚀 Suggest an idea for this project. rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement✨] Update cfg-if, syn, and trybuild dependencies

3 participants