Repository navigation
Conversation
lint/ holds a separate PyPI package. gcr-lint check runs the ruff rules that cards name in tool_gate and reports each finding as a card, with its severity and how well it is backed. Every run ends with how many stable cards the rules cover (9 of 202 in this release) and that a clean run is not a review. gcr-lint coverage lists them; gcr-lint config prints a ruff config. It adds no detection of its own. The map from rule codes to cards is src/goodcodereview_lint/data/gates.tsv, and a repository test fails when it or the card snapshot drifts from the cards. It is not published. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013wy5PKFLRYL7DhA4rqJ7kz
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
A new folder,
lint/, holds a separate PyPI package,goodcodereview-lint, with one command,gcr-lint. It is not published.gcr-lint check [paths]runs the ruff rules that cards name intool_gate, then reports each finding as a card: id, severity, how well the card is backed, and whether the rule is the card's whole check (full) or part of it (partial).gcr-lint coveragelists the covered cards.gcr-lint configprints a ruff config that selects the same rules.--fail-onsets the exit code.lint/src/goodcodereview_lint/data/gates.tsv;data/cards.jsonis a snapshot of the cards, rebuilt withpython3 lint/scripts/snapshot.py.test/test_lint.pyfails when the map points at a missing card or the snapshot drifts from the built cards, and runs ruff on small samples.Why Python, not Rust
The tool orchestrates ruff, which is already Rust, so its own speed does not matter. Python installs with
pipxoruvxand takes a contributor in minutes. Rust would pay off only for our own multi-language detection engine; that is a later decision.Checks
ruff,mypy,uv run pytest(159 tests) and a wheel build pass. I installed the wheel in an isolateduvxenvironment and rangcr-lint checkandcoverageon a sample. Nothing was published to PyPI.Review notes
Coverage is small on purpose and is printed on every run. The map covers nine cards today; adding rows is the way to grow it.
🤖 Generated with Claude Code
https://claude.ai/code/session_013wy5PKFLRYL7DhA4rqJ7kz