chore: do not ignore errors when clearing the npm/ output directory - #70
Merged
Conversation
rmSync already ignores a missing directory via force: true, so the try/catch only swallowed real errors such as EACCES or EBUSY. Since package.json ships the entire npm/ folder, a partially cleared output directory meant stale JavaScript from earlier builds could be published.
Member
Author
|
Non-significant change, no PR review required. |
coderbyheart
added
the
non-significant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rmSyncalready ignores a missing directory viaforce: true, so thetry/catchonly swallowed real errors such asEACCESorEBUSY. Sincepackage.jsonships the entirenpm/folder, a partially cleared output directory meant stale JavaScript from earlier builds could be published.Ports nRFCloud/wait-for-it@d1060ed to this repository.