Repository navigation
Conversation
Contributor
Author
|
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the history-field deprecation change.
No open issues 🎉
What changed in this PR
Deprecates vulnerability-history and mean-time-to-fix history fields in the Nais GraphQL API without removing them. Existing behavior remains available while usage by consumers other than Console is assessed.
Changes:
- Marks both history fields deprecated on
Query,Workload,Application,Job, andTeam. - Updates the generated schema to include the deprecation metadata.
- Adds a regression test ensuring all ten fields remain available with nonempty deprecation reasons.
| File | Description |
|---|---|
internal/graph/vulnerability.resolvers_test.go |
Tests field availability and deprecation metadata. |
internal/graph/schema/vulnerability.graphqls |
Deprecates history fields while preserving their contracts. |
internal/graph/gengql/root_.generated.go |
Reflects the deprecations in the generated schema. |
Review effort: Balanced
BREAKING CHANGE: Remove imageVulnerabilityHistory and vulnerabilityFixHistory from GraphQL. Deploy the Console removal before this API change.
Keep existing GraphQL consumers working while usage is assessed.
ybelMekk
force-pushed
the
remove-vulnerability-history-mttf
branch
from
November 20, 2026 08:24
4240712 to
e64d1f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Console slutter å bruke historikk og MTTF, men vi vet ennå ikke om andre GraphQL-konsumenter bruker feltene.
Markerer imageVulnerabilityHistory og vulnerabilityFixHistory som deprecated, men beholder implementasjonen og eksisterende oppførsel. Dette unngår kontraktbrudd mens bruken kartlegges. Endelig fjerning utsettes til konsumentene er avklart.
Edit: Bruken kan følges med den eksisterende metrikken nais_api_deprecated_field_usage etter at deprecation er deployet. Den viser hvilke felter som brukes, men ikke av hvem. Vi bruker dette som grunnlag før endelig fjerning.