Skip to content

refactor(vulnerabilities): fjern GraphQL-feltene for sårbarhetshistorikk og MTTF - #637

Draft
ybelMekk wants to merge 3 commits into
mainfrom
remove-vulnerability-history-mttf
Draft

ybelMekk wants to merge 3 commits into
mainfrom
remove-vulnerability-history-mttf

Conversation

@ybelMekk

@ybelMekk ybelMekk commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Console slutter å bruke historikk og MTTF, men vi vet ennå ikke om andre GraphQL-konsumenter bruker feltene.

Markerer  imageVulnerabilityHistory  og  vulnerabilityFixHistory  som deprecated, men beholder implementasjonen og eksisterende oppførsel. Dette unngår kontraktbrudd mens bruken kartlegges. Endelig fjerning utsettes til konsumentene er avklart.

Edit: Bruken kan følges med den eksisterende metrikken  nais_api_deprecated_field_usage  etter at deprecation er deployet. Den viser hvilke felter som brukes, men ikke av hvem. Vi bruker dette som grunnlag før endelig fjerning.

@ybelMekk

ybelMekk commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor Author

Denne PR-en trenger ikke merges nå. Når bruken er kartlagt og eventuelle konsumenter er håndtert, kan vi fjerne historikk-/MTTF-feltene og tilhørende implementasjon direkte. En separat deprecation-PR er bare nyttig dersom konsumentene trenger et migreringsvarsel

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the history-field deprecation change.

No open issues 🎉

What changed in this PR

Deprecates vulnerability-history and mean-time-to-fix history fields in the Nais GraphQL API without removing them. Existing behavior remains available while usage by consumers other than Console is assessed.

Changes:

  • Marks both history fields deprecated on Query, Workload, Application, Job, and Team.
  • Updates the generated schema to include the deprecation metadata.
  • Adds a regression test ensuring all ten fields remain available with nonempty deprecation reasons.
File Description
internal/​graph/​vulnerability.resolvers_test.go Tests field availability and deprecation metadata.
internal/​graph/​schema/​vulnerability.graphqls Deprecates history fields while preserving their contracts.
internal/​graph/​gengql/​root_.generated.go Reflects the deprecations in the generated schema.

Review effort: Balanced

BREAKING CHANGE: Remove imageVulnerabilityHistory and vulnerabilityFixHistory from GraphQL. Deploy the Console removal before this API change.
Keep existing GraphQL consumers working while usage is assessed.
@ybelMekk
ybelMekk force-pushed the remove-vulnerability-history-mttf branch from 4240712 to e64d1f1 Compare November 20, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants