Skip to content

ui: replace ds-svelte icons with Lucide - #185

Merged
rbjornstad merged 3 commits into
mainfrom
ui/replace-ds-svelte-icons
Nov 17, 2026
Merged

rbjornstad merged 3 commits into
mainfrom
ui/replace-ds-svelte-icons

Conversation

@rbjornstad

@rbjornstad rbjornstad commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Replace six homepage feature icons with Lucide, preserving inherited size, colors and decorative accessibility attributes.
  • Remove @nais/ds-svelte-community and unused transitive dependencies.
  • Pin @lucide/svelte to 1.67.0 to comply with the minimum release age policy.
  • Block TypeScript >=6.1.0 in Dependabot to match the installed typescript-eslint compatibility boundary, while allowing 6.0 patches. Exclude TypeScript from pnpm update, following Console policy.

Validation

  • pnpm run lint: passed
  • pnpm run check: passed with one existing warning about missing Node type definitions
  • pnpm run build: passed, including static prerendering and RSS generation

Visual browser verification has not been performed.

rbjornstad and others added 2 commits November 17, 2026 08:59
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The Dependabot safeguard still permits TypeScript 6.1 lockfile updates, violating typescript-eslint@8.72.1’s explicit <6.1.0 compatibility requirement.

1 open issue
1 file not reviewed
  • pnpm-lock.yaml: Generated file
What changed in this PR

Replaces the homepage’s design-system icons with Lucide, removes unused dependencies, and adds TypeScript update safeguards.

Changes:

  • Replace six feature icons while retaining inherited sizing, colors, and decorative accessibility attributes.
  • Pin @lucide/svelte to 1.67.0 and remove the previous icon package and unused transitive dependencies.
  • Ignore TypeScript major updates in Dependabot and exclude TypeScript from pnpm updates.
File Description
src/​lib/​Glances.svelte Replace six homepage icons with Lucide equivalents.
pnpm-workspace.yaml Exclude TypeScript from pnpm updates.
pnpm-lock.yaml Record Lucide and remove unused dependency entries.
package.json Replace the design-system dependency with pinned Lucide.
.github/​dependabot.yaml Ignore TypeScript major-version updates.

Review effort: Balanced

Comment thread .github/dependabot.yaml Resolved
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the homepage icon migration and dependency-update safeguards.

No open issues 🎉

1 resolved since last review
1 file not reviewed
  • pnpm-lock.yaml: Generated file

Review effort: Balanced

@rbjornstad
rbjornstad merged commit e3ed436 into main Nov 17, 2026
4 checks passed
@rbjornstad
rbjornstad deleted the ui/replace-ds-svelte-icons branch November 17, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants