Repository navigation
ui: replace ds-svelte icons with Lucide - #185
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The Dependabot safeguard still permits TypeScript 6.1 lockfile updates, violating typescript-eslint@8.72.1’s explicit <6.1.0 compatibility requirement.
1 open issue
1 file not reviewed
pnpm-lock.yaml: Generated file
What changed in this PR
Replaces the homepage’s design-system icons with Lucide, removes unused dependencies, and adds TypeScript update safeguards.
Changes:
- Replace six feature icons while retaining inherited sizing, colors, and decorative accessibility attributes.
- Pin
@lucide/svelteto1.67.0and remove the previous icon package and unused transitive dependencies. - Ignore TypeScript major updates in Dependabot and exclude TypeScript from pnpm updates.
| File | Description |
|---|---|
src/lib/Glances.svelte |
Replace six homepage icons with Lucide equivalents. |
pnpm-workspace.yaml |
Exclude TypeScript from pnpm updates. |
pnpm-lock.yaml |
Record Lucide and remove unused dependency entries. |
package.json |
Replace the design-system dependency with pinned Lucide. |
.github/dependabot.yaml |
Ignore TypeScript major-version updates. |
Review effort: Balanced
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Validation
Visual browser verification has not been performed.