Repository navigation
feat(authserver): remove client_credentials grant - #54
Merged
Merged
Conversation
Co-authored-by: Trong Huu Nguyen <trong.huu.nguyen@nav.no>
Co-authored-by: Trong Huu Nguyen <trong.huu.nguyen@nav.no>
Require client authentication audience checks for service account subject tokens, and machine token exchange without external subject token issuers.
Treat Kubernetes client authentication issuers like configured external issuers when verifying subject tokens, and set urn:nais:idp_name to nais for them. Token exchange no longer requires external issuers. Co-authored-by: Tommy Trøen <tommy.troen@nav.no>
Co-authored-by: Tommy Trøen <tommy.troen@nav.no>
…n issuers Internal issuers are always accepted as subject token issuers with the reserved name nais. Stop configuring the cluster issuer as an external issuer in Feature.yaml, which validation now rejects.
Co-authored-by: Trong Huu Nguyen <trong.huu.nguyen@nav.no>
Co-authored-by: Trong Huu Nguyen <trong.huu.nguyen@nav.no>
Co-authored-by: Trong Huu Nguyen <trong.huu.nguyen@nav.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Token exchange is now the only grant. Clients without user context send their own service account token as both
client_assertionandsubject_token.urn:nais:idpandurn:nais:idp_alias. The alias for client authentication issuers is configured per environment withclientAuthIssuerAlias(defaultkubernetes). External issuers cannot reuse an environment's issuer or alias.client_idandurn:nais:call_chain. Claims copied from the subject token describe that token, not the caller. Seedocs/usage.md.stspackage.m2mandobotoken tasks are renamed tointernalandexternal.Breaking changes:
client_credentialsis no longer supported.subjectTokenIssuersis renamed toexternalIssuers.urn:nais:idp_nameis renamed tourn:nais:idp_alias.