Handle Google Maps old Place Details error responses without decode failure - #1493
Draft
vijaygupta18 wants to merge 1 commit into
Draft
Handle Google Maps old Place Details error responses without decode failure#1493vijaygupta18 wants to merge 1 commit into
vijaygupta18 wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Argus proposed fix
Fix confidence: HIGH (score 0.85)
Reasons: RCA high-confidence, exact line identified, confirmed pattern matched, localized diff (3f/9l)
Root cause
The old Google Maps Place Details client decoded the response into GetPlaceDetailsResp which required a 'result' field. Google returns HTTP 200 error bodies (e.g. status=INVALID_REQUEST/NOT_FOUND) without that field, causing a DecodeFailure that the BAP app surfaced as HTTP 500. Making 'result' Maybe and adding NOT_FOUND to validateResponseStatus lets the existing status checker throw GoogleMapsInvalidRequest before the caller sees a malformed response.
Evidence
see RCA
Rollback
Revert the commit in shared-kernel and bump the backend dependency back to the previous shared-kernel version.
Draft PR — review and merge manually. Generated by Argus.