Skip to content

Handle Google Maps old Place Details error responses without decode failure - #1493

Draft
vijaygupta18 wants to merge 1 commit into
mainfrom
argus/fix-s1787901671
Draft

Handle Google Maps old Place Details error responses without decode failure#1493
vijaygupta18 wants to merge 1 commit into
mainfrom
argus/fix-s1787901671

Conversation

@vijaygupta18

Copy link
Copy Markdown
Member

🤖 Argus proposed fix

Fix confidence: HIGH (score 0.85)
Reasons: RCA high-confidence, exact line identified, confirmed pattern matched, localized diff (3f/9l)

Root cause

The old Google Maps Place Details client decoded the response into GetPlaceDetailsResp which required a 'result' field. Google returns HTTP 200 error bodies (e.g. status=INVALID_REQUEST/NOT_FOUND) without that field, causing a DecodeFailure that the BAP app surfaced as HTTP 500. Making 'result' Maybe and adding NOT_FOUND to validateResponseStatus lets the existing status checker throw GoogleMapsInvalidRequest before the caller sees a malformed response.

Evidence

see RCA

Rollback

Revert the commit in shared-kernel and bump the backend dependency back to the previous shared-kernel version.


Draft PR — review and merge manually. Generated by Argus.

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant