Repository navigation
Conversation
Czaki
reviewed
Oct 3, 2026
Comment on lines
+18
to
+21
| export NILEARN_DATA ?= $(LOCALAPPDATA)/napari-docs-nilearn | ||
| else | ||
| export NILEARN_DATA ?= $(if $(XDG_CACHE_HOME),$(XDG_CACHE_HOME),$(HOME)/.cache)/napari-docs-nilearn | ||
| endif |
Contributor
There was a problem hiding this comment.
conf.py might be better for this.
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| main(*sys.argv[1:]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Follow-up to #1148, which moved the prefetch before even prep-docs, causing offline builds like
slimfastto take longer locally and to fail on CI if the fetch fails.Description
This moves the prefecthing only for the steps that need it (gallery and executable notebooks), parsed with the script and implemented in the MAKEFILE. Then, it makes sure the cache is pointed to the OS-level cache which should persist across CI runs and is less complicated for our useal pooch fetches (nilearn is massaged where needed with the makefile)