Repository navigation
chore: group oxc-node updates, upgrade to v1, and fix CI setup - #1234
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Brooooooklyn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group
@oxc-node/*updates in Renovate, including major releases, and upgrade all three consuming workspaces to^1.0.1with the matching lockfile. CLI 1.0.1 requires Core 1.0.1; unrelated lockfile resolutions are unchanged.Repair the CI setup failures that prevented validation: install
cmake-coreon FreeBSD and invoke the repository's Yarn 4.18.1 through Node in all five container test steps. ARM64 Alpine now usesnode:${{ matrix.node }}-alpine, so the jobs named Node 22 and Node 24 run their intended versions.Local validation passed: strict Renovate validation and rule matching, immutable installation, lint, TypeScript build, formatting, workflow and shell syntax validation, and CLI smoke tests on Node 22/24. The pinned Yarn command also ran 24 xxhash tests successfully on each Node version with no global Yarn in PATH. Actionlint used a local config recognizing the already-used
ubuntu-26.04-armrunner label.CI for
727cab7completed successfully: all 38 PR checks passed, including 37 Actions jobs. FreeBSD and both ARM64 Alpine test jobs passed. The Publish job validated package assembly; itsLerna publishstep was skipped, so no release was published.Supplemental local jsonwebtoken coverage has one pre-existing ESM
__dirnamefailure under both Core 0.1.7 and 1.0.1; this test is outside the repository's default AVA glob.