Skip to content

Update core snapshot to netft-cpp 0.3.1 - #5

Merged
han-xudong merged 3 commits into
mainfrom
fix/netft-cpp-0.3.1
Jul 31, 2026
Merged

Update core snapshot to netft-cpp 0.3.1#5
han-xudong merged 3 commits into
mainfrom
fix/netft-cpp-0.3.1

Conversation

@han-xudong

@han-xudong han-xudong commented Jul 31, 2026

Copy link
Copy Markdown
Member

Updates the controlled native-core snapshot to netft-cpp v0.3.1 and aligns the fail-stop integration test with the upstream contract that FT-sequence discontinuity samples are not delivered.

Summary by CodeRabbit

  • Bug Fixes

    • Prevented stalled or backward force/torque sequence samples from being delivered before the related fault is reported.
    • Improved recovery behavior across supported recovery policies.
    • Updated recovery validation to confirm only valid samples are delivered.
  • Documentation

    • Updated the documented native core version to 0.3.1.
    • Added an Unreleased changelog entry describing the corrected sample handling.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@han-xudong, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 49 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 935d2278-5f18-4ac3-b803-11984324aef1

📥 Commits

Reviewing files that changed from the base of the PR and between 5e2bc07 and ace2e47.

📒 Files selected for processing (9)
  • .github/workflows/ci.yml
  • CHANGELOG.md
  • core/SNAPSHOT.sha256
  • core/UPSTREAM
  • core/app/cli.cpp
  • core/app/cli.hpp
  • core/app/main.cpp
  • tests/quality/test_sync_core.py
  • tools/sync_core.py
📝 Walkthrough

Walkthrough

The project now pins netft-cpp 0.3.1. FT stalls and backward-sequence discontinuities no longer deliver samples. Recovery tests and project documentation reflect the updated behavior.

Changes

netft-cpp 0.3.1 update

Layer / File(s) Summary
Upstream pin and release metadata
core/UPSTREAM, core/CMakeLists.txt, core/SNAPSHOT.sha256, README.md, CHANGELOG.md
The project references netft-cpp 0.3.1, updates snapshot hashes, and documents the FT-sequence behavior correction.
FT sample suppression and recovery validation
core/src/detail/client_impl.cpp, tests/integration/test_recovery.py
handle_record suppresses stalled and backward-sequence samples. The stall test now expects one delivered sample from two records.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant FTRecordSource
  participant HandleRecord as client_impl::handle_record
  participant SampleConsumer
  participant RecoveryPolicy
  FTRecordSource->>HandleRecord: deliver FT records
  HandleRecord->>RecoveryPolicy: evaluate stall or backward outcome
  HandleRecord->>SampleConsumer: deliver only valid FT samples
  HandleRecord->>RecoveryPolicy: clear matching outcome for reconnect recovery
Loading
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating the core snapshot to netft-cpp 0.3.1.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/netft-cpp-0.3.1

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
tests/integration/test_recovery.py (1)

156-164: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add a backward ft_sequence integration test.

Add a lower-ft_sequence case that expects FaultCode.FT_BACKWARD, last_ft_progress == "backward", and delivered_count == 1.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/integration/test_recovery.py` around lines 156 - 164, Add a backward
ft_sequence integration scenario alongside the existing recovery test, using the
client sample flow to trigger a lower sequence value and asserting
SensorFaultError with FaultCode.FT_BACKWARD. Verify the captured health reports
last_ft_progress as "backward" and delivered_count as 1, while preserving the
existing stall assertions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@tests/integration/test_recovery.py`:
- Around line 156-164: Add a backward ft_sequence integration scenario alongside
the existing recovery test, using the client sample flow to trigger a lower
sequence value and asserting SensorFaultError with FaultCode.FT_BACKWARD. Verify
the captured health reports last_ft_progress as "backward" and delivered_count
as 1, while preserving the existing stall assertions.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 268ccae5-b0c0-4668-bcae-e48f33a0f07c

📥 Commits

Reviewing files that changed from the base of the PR and between 4b17ddd and 5e2bc07.

📒 Files selected for processing (7)
  • CHANGELOG.md
  • README.md
  • core/CMakeLists.txt
  • core/SNAPSHOT.sha256
  • core/UPSTREAM
  • core/src/detail/client_impl.cpp
  • tests/integration/test_recovery.py

@han-xudong
han-xudong merged commit 0d5e666 into main Jul 31, 2026
27 checks passed
@han-xudong
han-xudong deleted the fix/netft-cpp-0.3.1 branch July 31, 2026 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant