feat: Implement ActivityResultContract by stefan-niedermann · Pull Request #1033 · nextcloud/Android-SingleSignOn

stefan-niedermann · 2026-07-15T14:16:32Z

Motivation:

Provide state-of-the-art access to Nextcloud Single Sign On
Hide complete permission granting and account importing process behind a clear API surface
Deprecate methods that rely on deprecated Android framework methods like onActivityResult
Enhance maintainability and make refactoring easier in the future when the deprecated methods have eventually been removed or marked as private

Refs: #448

Co-authored-by: Gemini

🤖 AI (if applicable)

The content of this PR was partly or fully generated using AI

Motivation: - Provide state-of-the-art access to Nextcloud Single Sign On - Hide complete permission granting and account importing process behind a clear API surface - Deprecate methods that rely on deprecated Android framework methods like onActivityResult - Enhance maintainability and make refactoring easier in the future when the deprecated methods have eventually been removed or marked as private Refs: #448 Co-authored-by: Gemini Signed-off-by: Stefan Niedermann <info@niedermann.it>

codacy-production · 2026-07-15T14:17:51Z

Not up to standards ⛔

🔴 Issues 1 minor

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results

CodeStyle 1 minor

View in Codacy

🟢 Metrics 14 complexity

Metric Results

Complexity 14

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

stefan-niedermann · 2026-07-15T14:36:13Z

Additional information

Exception Handling

A third party app can start the import process and gets either a SingleSignOnAccount instance or null. Displaying errors to the users is handled intentionally completely within the SSO lib.

This aligns with other ActivityResultContracts and gives the SSO lib the full control over exception handling for a uniform user experience across various 3rd party apps.

Theming

There are multiple sources of dialogs that may look different within the flow:

Native android dialogs like the account chooser
Permission dialogs from the files app
Exception dialogs from the SSO lib

Given this does not affect the (now) deprecated way of importing accounts, this can be enhanced progressively in my opinion, so this should not be a show stopper.
Maybe @AndyScherzinger has some ideas how to unify the styling in the complete flow?

Testing

Tested successfully manually on AVD API level 24 without Google Play Services and API Level 36.1 with Google Play Services.

github-actions · 2026-07-15T16:35:23Z

SpotBugs

Category	Base	New
Bad practice	9	9
Correctness	24	24
Dodgy code	13	16
Internationalization	2	2
Malicious code vulnerability	11	11
Multithreaded correctness	4	4
Performance	4	4
Security	7	7
Total	74	77

SpotBugs increased!

AndyScherzinger · 2026-07-16T13:57:12Z

Given this does not affect the (now) deprecated way of importing accounts, this can be enhanced progressively in my opinion, so this should not be a show stopper.
Maybe @AndyScherzinger has some ideas how to unify the styling in the complete flow?

@stefan-niedermann Likely depends on how they have been implemented. Lately we migrated various parts of the UI to Composables and with that we get theming "for free" in the sense that we now just to proper design tokens for styling and inject the apps server theme and are done, everything else properly managed by the Composables themselves now. SO no need for calling theme APIs any longer 🚀

github-actions · 2026-07-30T04:26:03Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

alperozturk96 · 2026-07-30T09:07:56Z

+
+        if (savedInstanceState == null) {
+
+            try {


Why nested try block used here?

alperozturk96 · 2026-07-30T09:08:44Z

+
+/// This is a Trampoline Activity that takes care about requesting all necessary permissions and guiding the user through the complete import flow.
+/// It is extremely important to catch *any* error and finish this activity because otherwise, the Trampoline Activity will stay on top but transparent, so users can't see it and users can't interact with their (visible) 3rd party app anymore.
+public class ImportSsoAccountActivity extends AppCompatActivity {


Can't we use Kotlin for new files?

Sure, one can do this. Please note, that (speaking for me personally only) enforcing Kotlin will stop further contributions from my side to this library. I don't want to trigger a "Kotlin vs. Java" discussion, this is a personal decision.

Of course Java is perfectly fine; it was just a question for new file.

Thank you for the PR :)

alperozturk96 · 2026-07-30T09:11:48Z

+    protected void onCreate(@Nullable Bundle savedInstanceState) {
+        super.onCreate(savedInstanceState);
+
+        if (savedInstanceState == null) {


We can fail fast here instead nested if.

alperozturk96 · 2026-07-30T09:12:09Z

+ *
+ * @see <a href="https://developer.android.com/training/basics/intents/result"><code>ActivityResultContract</code></a>
+ */
+public class ImportSsoAccount extends ActivityResultContract<Void, SingleSignOnAccount> {


Can't we use Kotlin for new files?

Refs: #448 Signed-off-by: Stefan Niedermann <info@niedermann.it>

github-actions · 2026-07-30T11:01:02Z

SpotBugs

Category	Base	New
Bad practice	9	9
Correctness	24	24
Dodgy code	13	16
Internationalization	2	2
Malicious code vulnerability	11	11
Multithreaded correctness	4	4
Performance	4	4
Security	7	7
Total	74	77

SpotBugs increased!

stefan-niedermann requested review from AndyScherzinger, David-Development and tobiasKaminsky July 15, 2026 14:16

stefan-niedermann linked an issue Jul 15, 2026 that may be closed by this pull request

Support Activity Result API #448

Open

AndyScherzinger requested a review from alperozturk96 July 16, 2026 13:53

github-actions Bot added the feedback-requested label Jul 30, 2026

alperozturk96 requested changes Jul 30, 2026

View reviewed changes

refactor: Simplify error handling in ImportSsoAccountActivity

d1e6abe

Refs: #448 Signed-off-by: Stefan Niedermann <info@niedermann.it>

Uh oh!

Conversation

stefan-niedermann commented Jul 15, 2026

🤖 AI (if applicable)

Uh oh!

codacy-production Bot commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Not up to standards ⛔

Uh oh!

stefan-niedermann commented Jul 15, 2026

Additional information

Exception Handling

Theming

Testing

Uh oh!

github-actions Bot commented Jul 15, 2026

SpotBugs

SpotBugs increased!

Uh oh!

AndyScherzinger commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 30, 2026

Uh oh!

alperozturk96 Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

alperozturk96 Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

stefan-niedermann Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

alperozturk96 Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alperozturk96 Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alperozturk96 Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 30, 2026

SpotBugs

SpotBugs increased!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codacy-production Bot commented Jul 15, 2026 •

edited

Loading

alperozturk96 Jul 30, 2026 •

edited

Loading