Skip to content

fix(capabilities): Enable unified sharing only for supported API version #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpivchev merged 1 commit into from
Oct 27, 2026
+11 −2
Merged

fix(capabilities): Enable unified sharing only for supported API version #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Sources/NextcloudKit/Models/UnifiedSharing/NKUnifiedSharingCapabilities.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ import Foundation

/// The `sharing` block of the server capabilities, describing unified-sharing support.
public struct NKUnifiedSharingCapabilities: Codable, Sendable {
/// The unified-sharing API version this client implements.
static let unifiedShareApiVersion = "v1"

public let apiVersions: [String]
public let sourceTypes: [NKUnifiedShareSourceType]
public let permissionPresets: [NKUnifiedSharePermissionPreset]
Expand Down
10 changes: 8 additions & 2 deletions Sources/NextcloudKit/NextcloudKit+Capabilities.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,13 @@ public extension NextcloudKit {

struct Governance: Codable {}

struct Sharing: Codable {}
struct Sharing: Codable {
let apiVersions: [String]?

enum CodingKeys: String, CodingKey {
case apiVersions = "api_versions"
}
}

struct DownloadLimit: Codable {
let enabled: Bool?
Expand Down Expand Up @@ -399,7 +405,7 @@ public extension NextcloudKit {
capabilities.fileSharingDownloadLimit = json.downloadLimit?.enabled ?? false
capabilities.fileSharingDownloadLimitDefaultLimit = json.downloadLimit?.defaultLimit ?? 1

capabilities.unifiedSharingEnabled = json.sharing != nil
capabilities.unifiedSharingEnabled = json.sharing?.apiVersions?.contains(NKUnifiedSharingCapabilities.unifiedShareApiVersion) ?? false

capabilities.themingColor = json.theming?.color ?? ""
capabilities.themingColorElement = json.theming?.colorelement ?? ""
Expand Down
Loading