fix(deploy): round the memory and CPU limits to whole numbers

[oleksandr-nc]

The daemon settings convert the CPU limit with Number(cpus) * 1000000000, so some values come out with a fraction: 1.07 CPUs is stored as 1070000000.0000001 and 2.01 as 2009999999.9999998 (50 of the 1600 two-decimal values up to 16, among them 4.1 and 8.2). AppAPI sent the value on unchanged. On Docker every deploy and update on that daemon failed, because Docker does not accept a fraction and HaRP now refuses it before creating the container, and an update left the ExApp without a container, because the old one is removed first. On Kubernetes HaRP dropped the fractional value, so those ExApps ran without a CPU limit.

AppAPI now rounds memory and nanoCPUs to whole numbers when it builds the deploy parameters for Docker (HaRP and Docker Socket Proxy) and Kubernetes, so it also works for limits that are already stored. Kubernetes ExApps on such a daemon get the configured CPU limit with their next deploy or update. Other values are passed on unchanged.

[oleksandr-nc]

/backport to stable35

[oleksandr-nc]

/backport to stable34

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: fafb48f7-9eb2-401b-99ee-be686d76239a

📥 Commits

Reviewing files that changed from the base of the PR and between cc9a044 and 0975efc.

📒 Files selected for processing: 3

• tests/php/DeployActions/DockerActionsTest.php
• tests/php/DeployActions/KubernetesActionsTest.php
• tests/php/Service/AppAPICommonServiceTest.php

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

📝 Walkthrough

AppAPICommonService::buildResourceLimits returns an empty array when resourceLimits is not an array. For float values of memory and nanoCPUs whose absolute values are below PHP_INT_MAX, it rounds and casts the values to integers. Other entries remain unchanged. Docker and Kubernetes deployment parameter builders now use this method. Tests cover these cases.

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to 0975e

Fractional UI-derived limits are normalized to integer bytes and nanocpus before deployment. The inspected consumers support those units, and no actionable merge-blocking risk is established; merge after normal checks.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 10.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 6 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly and concisely describes the main change: rounding memory and CPU resource limits to whole numbers.
Description check		The description directly explains the fractional resource-limit problem, the affected deployment paths, and the implemented rounding behavior.

• Fix all pre-merge checks with AI

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 38e3131a-720a-49c9-88b3-53b421c0c818

📥 Commits

Reviewing files that changed from the base of the PR and between 590ed3f and cc9a044.

📒 Files selected for processing: 4

• lib/DeployActions/DockerActions.php
• lib/DeployActions/KubernetesActions.php
• lib/Service/AppAPICommonService.php
• tests/php/Service/AppAPICommonServiceTest.php

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.