Repository navigation
feat(AgencyConfirmation): display impulse radius of pending actions #661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
edward-ly
wants to merge
4
commits into
main
Choose a base branch
from
feat/noid/impulse-radius-front
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
1cc6475
feat(AgencyConfirmation): display impulse radius of pending actions
edward-ly 5e1c1f0
docs(AgencyConfirmation): add context for translators
edward-ly 3b25b34
feat(AgencyConfirmation): update description and dialog type for pend…
edward-ly 1f364d1
fix(AgencyConfirmation): separate computation of radius and destructi…
edward-ly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are assuming the assistant PHP API will just give you
impulse_radiusanddestructivefrom /check_generation, but without making any changes there I don't see how this should be the case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there another way to retrieve that info from the tools? I haven't seen anything else so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check my PR. Impulse radius and destrucive attributes of a context agent interaction task are returned here: https://github.com/nextcloud/context_agent/pull/236/changes#diff-305e63f17441090583e8f7affee7120e17c3017bfcd1eb38b27150af3707bf06R297-R308
We need to store these in the database in assistant, likely somewhere around here: https://github.com/nextcloud/assistant/blob/main/lib/Listener/ChattyLLMTaskListener.php#L156-L161. We cannot change the content of the 'actions' output, because people may still be using old versions of assistant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it looks like pending actions are stored in the DB (
Sessiontable) as a JSON string, so we don't have to modify the DB at all. And the only endpoints where I see the actions string is decoded are/check_generationand/check_session. I'm not sure what other solutions there are other than storingimpulse_radiusanddestructivewithin thependingActionsstring in this table.