Skip to content

feat(translations): add NextcloudKit string catalog #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpivchev merged 1 commit into from
Oct 19, 2026
Merged

feat(translations): add NextcloudKit string catalog #1011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 40 additions & 28 deletions translations/handleNextcloudKitTranslations.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ gpg --list-keys
# fetch git repo
git clone git@github.com:nextcloud/NextcloudKit /app --depth 1

CATALOG=Sources/NextcloudKitUI/Localizable.xcstrings
# each Transifex resource syncs one catalog (see .tx/config)
CATALOGS="Sources/NextcloudKit/Localizable.xcstrings:translations/nextcloudkit/de_DE.xcstrings Sources/NextcloudKitUI/Localizable.xcstrings:translations/nextcloudkitui/de_DE.xcstrings"

# An XCSTRINGS upload replaces the translations of every language with the file's content,
# so pull the current translations first and upload them unchanged together with the source strings.
Expand All @@ -24,40 +25,51 @@ CATALOG=Sources/NextcloudKitUI/Localizable.xcstrings
# (onlytranslated leaves out the English fallbacks for untranslated strings)
tx pull --force --languages de_DE --mode onlytranslated

# never push without the translations from Transifex, the upload would delete all of them
COUNT_TRANSLATIONS='[.strings[] | (.localizations // {}) | keys[] | select(. != "en")] | length'
ONLINE_TRANSLATIONS=$(jq "$COUNT_TRANSLATIONS" translations/de_DE.xcstrings)
REPO_TRANSLATIONS=$(jq "$COUNT_TRANSLATIONS" "$CATALOG")

if [ "$ONLINE_TRANSLATIONS" -eq 0 ] && [ "$REPO_TRANSLATIONS" -gt 0 ]; then
echo "Transifex returned no translations while the catalog has $REPO_TRANSLATIONS, not pushing"
exit 1
fi

# push sources: our strings without stale ones (not present in code, detected by Xcode), with the translations from Transifex
jq --slurpfile online translations/de_DE.xcstrings '
.strings |= with_entries(
select(.value.extractionState != "stale")
| .key as $key
| ((.value.localizations // {} | with_entries(select(.key == "en"))) + ($online[0].strings[$key].localizations // {} | del(.en))) as $localizations
| if $localizations == {} then .value |= del(.localizations) else .value.localizations = $localizations end
)
' "$CATALOG" > FixedLocalizable.xcstrings
mv -f FixedLocalizable.xcstrings "$CATALOG"

for ENTRY in $CATALOGS; do
CATALOG=${ENTRY%%:*}
ONLINE=${ENTRY#*:}
Comment on lines +30 to +32

# never push without the translations from Transifex, the upload would delete all of them
ONLINE_TRANSLATIONS=$(jq "$COUNT_TRANSLATIONS" "$ONLINE")
REPO_TRANSLATIONS=$(jq "$COUNT_TRANSLATIONS" "$CATALOG")

if [ "$ONLINE_TRANSLATIONS" -eq 0 ] && [ "$REPO_TRANSLATIONS" -gt 0 ]; then
echo "Transifex returned no translations for $CATALOG while it has $REPO_TRANSLATIONS, not pushing"
exit 1
fi

# push sources: our strings without stale ones (not present in code, detected by Xcode), with the translations from Transifex
jq --slurpfile online "$ONLINE" '
.strings |= with_entries(
select(.value.extractionState != "stale")
| .key as $key
| ((.value.localizations // {} | with_entries(select(.key == "en"))) + ($online[0].strings[$key].localizations // {} | del(.en))) as $localizations
| if $localizations == {} then .value |= del(.localizations) else .value.localizations = $localizations end
)
' "$CATALOG" > FixedLocalizable.xcstrings
mv -f FixedLocalizable.xcstrings "$CATALOG"
done

tx push -s

# use de_DE instead of de, and sr-Latn for sr@latin, which iOS doesn't recognize (other Transifex codes work as they are)
jq '
{"de_DE": "de", "sr@latin": "sr-Latn"} as $codes
| .strings[] |= (if .localizations then .localizations |= (del(.de) | with_entries(.key |= ($codes[.] // .)) | to_entries | sort_by(.key) | from_entries) else . end)
' "$CATALOG" > FixedLocalizable.xcstrings
for ENTRY in $CATALOGS; do
CATALOG=${ENTRY%%:*}

# use de_DE instead of de, and sr-Latn for sr@latin, which iOS doesn't recognize (other Transifex codes work as they are)
jq '
{"de_DE": "de", "sr@latin": "sr-Latn"} as $codes
| .strings[] |= (if .localizations then .localizations |= (del(.de) | with_entries(.key |= ($codes[.] // .)) | to_entries | sort_by(.key) | from_entries) else . end)
' "$CATALOG" > FixedLocalizable.xcstrings

# keep Xcode's "key" : value formatting
sed -E 's/^( *"([^"\\]|\\.)*"): /\1 : /' FixedLocalizable.xcstrings > "$CATALOG"
# keep Xcode's "key" : value formatting
sed -E 's/^( *"([^"\\]|\\.)*"): /\1 : /' FixedLocalizable.xcstrings > "$CATALOG"
git add "$CATALOG"
done
rm -rf FixedLocalizable.xcstrings translations

# create git commit and push it
git add "$CATALOG"
git commit -m "fix(l10n): Update translations from Transifex" -s || true
git push origin main
echo "done"
Loading