Conversation
…ffice app is enabled Since nextcloud#2301, when the onlyoffice or officeonline app is enabled, richdocuments stops handling Microsoft Office formats (docx, xlsx, pptx…) and only keeps OpenDocument formats, so that each app handles its own family of formats. Some admins want the opposite: keep opening every format with Collabora by default, and let users pick the other app from the file actions menu ("Open in ONLYOFFICE"), per document. See nextcloud#3456 (and the earlier nextcloud#928). Add an opt-in admin setting, msoffice_with_other_office_apps (default off, so nothing changes for existing installations). When enabled, hasOtherOOXMLApps() returns false and MS Office mimetypes stay in the default list. Exposed like disable_certificate_verification: settings controller, admin initial state, capabilities, a checkbox in the admin settings (Advanced settings) and a paragraph in docs/app_settings.md. Tested on Nextcloud 34.0.3 with richdocuments 11.1.1 and onlyoffice 10.1.2 (with the OnlyOffice connector's default formats released): option enabled, a click opens Collabora and "Open in ONLYOFFICE" is offered in the menu; option disabled, the current behaviour is unchanged (ONLYOFFICE takes the click, Collabora is not offered). Resolves: nextcloud#3456 Signed-off-by: acbelle59 <acbelle@laposte.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #2301, when the
onlyoffice(orofficeonline) app is enabled, richdocuments stops handling Microsoft Office formats (docx, xlsx, pptx…) and only keeps OpenDocument formats, so that each app handles its own family of formats. That is a sensible default, but some admins want the opposite: keep opening every format with Collabora by default, and let users pick the other app from the file actions menu ("Open in ONLYOFFICE"), per document — see #3456 (and the earlier #928).This adds an opt-in admin setting,
msoffice_with_other_office_apps(default off, so nothing changes for existing installations). When enabled,hasOtherOOXMLApps()returnsfalseand the MS Office mimetypes stay in the default list. It is exposed exactly likedisable_certificate_verification: settings controller, admin initial state, capabilities, a checkbox in the admin settings (Advanced settings, under "Use OOXML by default"), and a paragraph indocs/app_settings.md.How it was tested
Nextcloud 34.0.3, richdocuments 11.1.1, onlyoffice 10.1.2 (with the OnlyOffice connector's default formats released so that it does not claim the simple click):
Resolves #3456.