Repository navigation
Verified vault build: use stellar-cli 28.1.0 - #65
Merged
Merged
Conversation
The first nirium-vault-v0.1.0 run failed: soroban-sdk 29 refuses to build with stellar-cli 25.1.0, which the pinned v25.1.0 workflow uses. Pin the workflow main commit 6b16426 instead (stellar-cli 28.1.0). The only other change upstream since v25.1.0 is actions/checkout v4 to v6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
M0nsxx
approved these changes
Nov 9, 2026
M0nsxx
left a comment
M0nsxx
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed. The first vault tag run failed because the pinned workflow installs stellar-cli 25.1.0 and soroban-sdk 29 needs 25.2.0+. This pins the workflow's main commit (stellar-cli 28.1.0). The upstream diff is only the CLI version and checkout v4 to v6. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first
nirium-vault-v0.1.0tag run failed at the build step:Run: https://github.com/nirium-protocol/nirium-core/actions/runs/42677296301
The pinned workflow (
stellar-expert/soroban-build-workflowv25.1.0) installs stellar-cli 25.1.0, and our contracts use soroban-sdk 29.0.1. There is no newer release of that workflow, so this pins its main commit6b16426(4 Oct 2026), which installs stellar-cli 28.1.0.I read the whole diff between the old pin and the new one. It's two lines: the CLI version (25.1.0 to 28.1.0) and
actions/checkoutv4 to v6. Nothing else changed.The failed run published no release and registered nothing, so after this merges the same tag can be recreated on the new main.
🤖 Generated with Claude Code