Repository navigation
Conversation
Commit a03e01f ("Bluetooth: add J813 N1 native transport and encrypted connection bring-up") rewrote drivers/bluetooth/Makefile from an older copy of the file. Besides its own additions it dropped: - the mt7932_bt_pcie rule added by 1d4782c ("Bluetooth: add opt-in J700 MT7932 PCIe transport experiment"), so CONFIG_BT_MTK7932_PCIE=m builds nothing and the J700 Bluetooth function has no driver; - CONTEXT_ANALYSIS := y from e01e99a ("Bluetooth: enable context analysis"). Restore both. The PCMCIA rules it re-added (dtl1_cs, bt3c_cs, bluecard_cs) have no Kconfig symbols since 794b5e7 and are inert; they are left for a separate cleanup. Tested on J700 (MacBook Neo) at 9127278: mt7932_bt_pcie.ko is built and loads, and the controller registers as hci0. Signed-off-by: Bartosz Nitka <niteria@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Sent upstream as aurora-silicon#1055 (rebased onto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For review before sending upstream to
aurora-silicon/linux. The base branchbase/aurora-9127278is the revision the Neo runs. Upstreamintegration/auroraHEAD (33bec40) still has the same Makefile, so the commit should apply there unchanged.Problem. a03e01f ("Bluetooth: add J813 N1 native transport…", merged via aurora-silicon#998) rewrote
drivers/bluetooth/Makefilefrom an older copy of the file. It dropped the J700mt7932_bt_pcierule, soCONFIG_BT_MTK7932_PCIE=mbuilds nothing, and it droppedCONTEXT_ANALYSIS := y. It also re-added three PCMCIA rules whose Kconfig symbols were removed in 794b5e7. Those are inert, so this PR leaves them for a separate cleanup.Change. Restore the two dropped lines.
Tested on the Neo (J700), generation 36 = 9127278 plus this change as a local patch:
mt7932_bt_pcie.kois built and loads,neo-mt7932-bluetooth-admissionsucceeds, andbluetoothctl listshows the controller (hci0). Without it, the admission unit fails withModule mt7932_bt_pcie not found.Open question for you. Restoring
CONTEXT_ANALYSISmakes no difference with GCC, which is what we build with. With Clang it re-enables context analysis for all ofdrivers/bluetooth, which upstream had before a03e01f but which hasn't been checked since. If you'd rather send only the mt7932 rule, drop that line.🤖 Generated with Claude Code