Skip to content

Report CLI test coverage across packages and subprocesses - #132

Merged
nnutter merged 9 commits into
timber-axon-kitfrom
timber
Nov 21, 2026
Merged

nnutter merged 9 commits into
timber-axon-kitfrom
timber

Conversation

@nnutter

@nnutter nnutter commented Nov 20, 2026 •

Copy link
Copy Markdown
Owner

No description provided.

@nnutter
nnutter added this pull request to stack #133 November 20, 2026 21:37
@nnutter nnutter changed the title timber Report CLI test coverage across packages and subprocesses Nov 20, 2026
@nnutter
nnutter force-pushed the timber branch 2 times, most recently from e1206ed to ac9bc13 Compare November 20, 2026 22:18
Run command and output checks in-process so Go can measure the code they
exercise. Keep subprocesses for Git command dispatch, terminal behavior,
and process death. Give the lock fixture more time to start under test
load.

Change-Id: Ia67d271ff9366365110d461e2f2c408bb5aede34
Count production blocks reached by in-process commands even when the
test and implementation live in different packages. Keep the regular
test task unchanged so routine checks do not pay for full
instrumentation.

Change-Id: I53a12c7c6fbad19d393f6a95fa66090130e8ed1f
Keep the tuicr store lookup scoped to the repository so concurrent tests
can give each checkout its own home without changing the process home.

Change-Id: I58463ad472335eee1647e5a5503e1a4320eb3a3f
Run cases together when they use separate repositories and do not change
the process environment. Leave cases with shared state in sequence.

Change-Id: I80085fa0fc81080238a03619d2f5c1984b18c098
The alias and file argument tests already check that each result names
the right review type. Removing the duplicate leaves coverage unchanged.

Change-Id: I1e00e088659c02acb4445a42024b8fd47dfbe108
Terminal, shell dispatch, and signal tests need the real process
boundary. Build instrumented test binaries on demand and collect their
counters separately so those tests do not look like uncovered Go code.

A process killed without a chance to exit cannot flush its counters; its
test still guards the process-lifetime contract.

Change-Id: I7ea17f7a9356216cadcf387b8ee4a983d707482e
Concurrent review tests need separate executable search paths and
settings without changing the process environment.

Change-Id: I63deefa03e98f2535c61986557236d2619a5c110
Each workflow has its own checkout, fake review tool, and saved
sessions. Run independent cases together, but leave cases that share a
checkout in sequence. Give the lock fixture more time to start under
parallel load.

Change-Id: I6bd5ed71e3c8e47a4987541bdd3ca5e049df0f3d
The CLI test already verifies that a file review without a saved session
returns a cancelled result. Removing the duplicate leaves coverage
unchanged.

Change-Id: I3a6632c861521b24a650b4bb13add7190b1de5df
@nnutter
nnutter merged commit 96f9ad4 into master Nov 21, 2026
3 of 6 checks passed
@nnutter
nnutter deleted the timber branch November 21, 2026 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant