Repository navigation
Report CLI test coverage across packages and subprocesses - #132
Merged
Merged
Conversation
nnutter
force-pushed
the
timber
branch
2 times, most recently
from
November 20, 2026 22:18
e1206ed to
ac9bc13
Compare
Run command and output checks in-process so Go can measure the code they exercise. Keep subprocesses for Git command dispatch, terminal behavior, and process death. Give the lock fixture more time to start under test load. Change-Id: Ia67d271ff9366365110d461e2f2c408bb5aede34
Count production blocks reached by in-process commands even when the test and implementation live in different packages. Keep the regular test task unchanged so routine checks do not pay for full instrumentation. Change-Id: I53a12c7c6fbad19d393f6a95fa66090130e8ed1f
Keep the tuicr store lookup scoped to the repository so concurrent tests can give each checkout its own home without changing the process home. Change-Id: I58463ad472335eee1647e5a5503e1a4320eb3a3f
Run cases together when they use separate repositories and do not change the process environment. Leave cases with shared state in sequence. Change-Id: I80085fa0fc81080238a03619d2f5c1984b18c098
The alias and file argument tests already check that each result names the right review type. Removing the duplicate leaves coverage unchanged. Change-Id: I1e00e088659c02acb4445a42024b8fd47dfbe108
Terminal, shell dispatch, and signal tests need the real process boundary. Build instrumented test binaries on demand and collect their counters separately so those tests do not look like uncovered Go code. A process killed without a chance to exit cannot flush its counters; its test still guards the process-lifetime contract. Change-Id: I7ea17f7a9356216cadcf387b8ee4a983d707482e
Concurrent review tests need separate executable search paths and settings without changing the process environment. Change-Id: I63deefa03e98f2535c61986557236d2619a5c110
Each workflow has its own checkout, fake review tool, and saved sessions. Run independent cases together, but leave cases that share a checkout in sequence. Give the lock fixture more time to start under parallel load. Change-Id: I6bd5ed71e3c8e47a4987541bdd3ca5e049df0f3d
The CLI test already verifies that a file review without a saved session returns a cancelled result. Removing the duplicate leaves coverage unchanged. Change-Id: I3a6632c861521b24a650b4bb13add7190b1de5df
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.