Update CI actions and test on current Node LTS versions - #989
Conversation
Bump actions/checkout to v7, actions/setup-node to v7, codecov/codecov-action to v7, github/codeql-action to v4 and actions/stale to v11. Codecov v4 and later need an upload token, so pass CODECOV_TOKEN. Test and lint on Node 18, 20, 22, 24 and 26 without failing fast, as node-saml does, and give the build workflow read-only contents access. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cjbarth
added
dependencies
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe GitHub workflows update action versions and test and lint configuration. The test and lint matrices cover Node.js 18, 20, 22, 24, and 26. The test workflow adds read-only ChangesGitHub Actions workflow updates
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to The supplied evidence identifies no merge-blocking workflow regression, including for fork coverage uploads. The PR is ready for normal CI validation. Architecture SummaryArchitecture risk: 🔵 Low · up to The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency. Changed systems: None identified. Architecture concerns Review detailsBefore / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #989 +/- ##
=======================================
Coverage 65.77% 65.77%
=======================================
Files 4 4
Lines 149 149
Branches 37 37
=======================================
Hits 98 98
Misses 41 41
Partials 10 10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 participant
This follows #987, which updated the npm dependencies but not the workflows.
Changes
actions/checkoutv4 → v7actions/setup-nodev3 → v7codecov/codecov-actionv3.1.4 → v7github/codeql-actionv3 → v4 (v3 is deprecated in December 2026)actions/stalev5 → v11CODECOV_TOKEN, which Codecov v4 and later require. PRs from forks still upload without a token.latest.fail-fast: falsereports every version that fails, not just the first.latestentry is dropped because 26 is the current release. Itsexperimentalflag was never wired tocontinue-on-error, so it didn't allow failures anyway.workflow.ymlnow declarespermissions: contents: read.This matches node-saml's workflow, and xml-crypto's for the Codecov token and permissions.
None of the breaking changes in these majors apply here:
package.jsonhas apackageManagerfield, and this one doesn't.pull_request_targetandworkflow_run, which these workflows don't use.Verification
actionlint and Prettier pass. The CI run on this PR uses the new actions and the full Node matrix.
Dependabot
Supersedes #972, #973, #974, #975 and #976.
🤖 Generated with Claude Code
Summary by CodeRabbit