fix: omit <Transforms> element when no transforms are specified - #542

Open

msheby wants to merge 25 commits into

node-saml:masterfrom

msheby:fix/omit-empty-transforms-clean

Commits on Aug 11, 2026

fix: omit <Transforms> element when no transforms are specified
Matthew Sheby
committed
7e30184
test: replace non-null assertions with deep.equal on ref.transforms
Matthew Sheby
committed
e33343c

Commits on Aug 12, 2026

test: cover both omitted and empty transforms in Transforms-omission test
Matthew Sheby
committed
21df3b8
fix: derive ancestor namespaces from the referenced node, not re-running xpath
Matthew Sheby
committed
c5d1976

Commits on Aug 17, 2026

docs: expand buildAncestorNsForElement JSDoc and fix prettier formatting
Matthew Sheby
committed
3a2a63c

Commits on Sep 8, 2026

Merge branch 'master' into fix/omit-empty-transforms-clean
cjbarth
authored
ebd058c
fix: guard against undefined transforms in enveloped-signature check
Matthew Sheby
committed
9e24d28
test: exercise addAllReferences multi-match in ancestor-namespace regression test
Matthew Sheby
committed
82bc488
Merge branch 'master' into pr/542

cjbarth
and
claude
committed
1834d27
fix: keep Reference.transforms required and tighten review follow-ups

cjbarth
and
claude
committed
6e16874
refactor: fold findAncestorNsForNode wrapper into its helper

cjbarth
and
claude
committed
6a7ac33
refactor: replace `export *` in index.ts with explicit re-export lists

cjbarth
and
claude
committed
6920712
Merge branch 'node-saml:master' into fix/omit-empty-transforms-clean
msheby
authored
bcc7e78
test: cover the non-element document subset guard in findAncestorNs

cjbarth
and
claude
committed
c6bb8c0
Lint
cjbarth
committed
a0b3e14

Commits on Sep 9, 2026

fix: assert element-ness in getCanonReferenceXml instead of silently skipping

cjbarth
and
claude
committed
6395317
test: assert refusal rather than a dependency's error wording

cjbarth
and
claude
committed
1efc2c1
fix: reject signing a reference that encloses the signature without a transform

cjbarth
and
claude
committed
ce8d32a
refactor: let algorithms declare whether they drop nodes

cjbarth
and
claude
committed
abfa1ad
fix!: require removesNodes on CanonicalizationOrTransformationAlgorithm

cjbarth
and
claude
committed
a752144
fix: enforce removesNodes at runtime and let subclasses declare it

cjbarth
and
claude
committed
f7d916d
fix: validate removesNodes in findCanonicalizationAlgorithm

cjbarth
and
claude
committed
7514d6d
docs: state that removesNodes is enforced on verification too

cjbarth
and
claude
committed
dcc89d4

Commits on Sep 10, 2026

Merge branch 'master' into fix/omit-empty-transforms-clean
Matthew Sheby
committed
1b9ce75

Commits on Sep 11, 2026

fix: drop unreachable nullish fallback on reference transforms
Matthew Sheby
committed
faab399