Skip to content

fix: report a validated node or reference only after the signature verifies #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cjbarth wants to merge 2 commits into from
Closed

fix: report a validated node or reference only after the signature verifies #591

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0956d06
fix: report a validated node or reference only after the signature ve…
cjbarth Sep 14, 2026
2af7aa1
Merge branch 'master' into fix/validated-node-requires-verified-signa…
cjbarth Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/signed-xml.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,9 @@ export class SignedXml {

/* eslint-disable-next-line deprecation/deprecation */
for (const ref of this.getReferences()) {
if (ref.signedReference === undefined) {
continue;
}
const uri = ref.uri?.[0] === "#" ? ref.uri.substring(1) : ref.uri;

for (const attr of this.idAttributes) {
Expand Down Expand Up @@ -570,12 +573,12 @@ export class SignedXml {

ref.getValidatedNode = deprecate((xpathSelector?: string) => {
xpathSelector = xpathSelector || ref.xpath;
if (typeof xpathSelector !== "string" || ref.validationError != null) {
if (typeof xpathSelector !== "string" || ref.signedReference === undefined) {
return null;
}
const selectedValue = xpath.select1(xpathSelector, doc);
return isDomNode.isNodeLike(selectedValue) ? selectedValue : null;
}, "`ref.getValidatedNode()` is deprecated and insecure. Use `ref.signedReference` or `this.getSignedReferences()` instead.");
}, "`ref.getValidatedNode()` is deprecated and insecure. Use `getSignedReferences()` instead.");

if (!isDomNode.isNodeLike(elem)) {
const validationError = new Error(
Expand Down