test: prove behavior through supported APIs instead of deprecated ones

[cjbarth]

Summary

The README tells consumers to stop using getReferences(), getOriginalXmlWithIds() and getValidatedNode(), but the tests still used them behind deprecation/deprecation suppressions. Where the supported API can prove the same behavior, the tests now use it. Where only a deprecated API can express the behavior, the test stays behind its suppression until that API is removed. The test count goes from 312 to 315.

Moved to the supported API, still proving the same behavior

• ds:Object tests: checkSignature() is asserted directly instead of collecting validation errors from getReferences().
• Every fixture passing verification: the getSignedReferences() length is compared with the Reference elements in the loaded signature.
• Signature loading: the getSignedReferences() length check becomes an assertion on their exact content.

Added

• Reading signed data: a test that parses getSignedReferences()[0] and selects the mail attribute, the supported counterpart of the getValidatedNode() tests.
• Detached signature over elements that carry their IDs: the document already carries its ID and is verified alongside getSignatureXml(), as the getOriginalXmlWithIds() deprecation advice describes.

Kept until removal

These can only be expressed through a deprecated API, so they stay until it is removed:

• getOriginalXmlWithIds(): the detached signature test, which signs a document without IDs and verifies the XML the method returns.
• getValidatedNode(): its five tests.
• getReferences(): the reference fields checked while loading a signature, the reference count before verification, and the DigestValue read past a comment.
• ref.signedReference: stays unset after checkSignature() throws.
• validateElementAgainstReferences(): its test call, behind the same suppression chore: deprecate validateElementAgainstReferences() #592 adds.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
  • Expanded coverage for signed XML references, including validation of serialized reference content and XPath parsing.
  • Added verification scenarios for detached signatures with both generated and pre-existing document identifiers.
  • Strengthened signature validation checks to confirm the expected number and content of signed references.
  • Simplified test assertions for clearer reporting of signature verification results.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 64dfc4c0-34f7-412d-a90a-4caa57423f2b

📥 Commits

Reviewing files that changed from the base of the PR and between 5f7da8f and 00e6ad9.

📒 Files selected for processing (4)

• test/document-tests.spec.ts
• test/signature-integration-tests.spec.ts
• test/signature-object-tests.spec.ts
• test/signature-unit-tests.spec.ts

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The test suite adds signed-reference content checks, separates detached-signature ID scenarios, and updates signature verification assertions to use direct boolean results.

Changes

Signature Test Coverage

Layer / File(s)	Summary
Signed-reference validation test/document-tests.spec.ts, test/signature-unit-tests.spec.ts	Tests validate signed-reference XML content, mail attribute extraction, exact serialized references, and reference counts from parsed signature data.
Detached-signature ID cases test/signature-integration-tests.spec.ts	Detached-signature tests distinguish generated IDs from input XML containing Id="_0" and select the corresponding XML for verification.
Signature verification assertions test/signature-object-tests.spec.ts	The test helper returns the verification boolean directly, and all call sites assert that boolean.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: shunkica

Merge Risk: ⚪ Minimal · up to 00e6a

The updated tests exercise supported signature APIs and detached-signature ID variants without an identified regression. The change is ready to merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 4 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely summarizes the main change: updating tests to verify behavior through supported APIs instead of deprecated APIs.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.78%. Comparing base (f5c4d22) to head (00e6ad9).
⚠️ Report is 19 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #593      +/-   ##
==========================================
+ Coverage   75.95%   79.78%   +3.83%     
==========================================
  Files           9        9              
  Lines        1048     1118      +70     
  Branches      273      283      +10     
==========================================
+ Hits          796      892      +96     
+ Misses        144      129      -15     
+ Partials      108       97      -11     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.