Skip to content

doc: discourage AbortSignal cleanup for long-lived resources - #64342

Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
efekrskl:doc/deprecate-signal-long-lived
Aug 23, 2026
Merged

doc: discourage AbortSignal cleanup for long-lived resources#64342
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
efekrskl:doc/deprecate-signal-long-lived

Conversation

@efekrskl

@efekrskl efekrskl commented Jul 7, 2026

Copy link
Copy Markdown
Member

Closes #48725

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net
  • @nodejs/userland-migrations

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Jul 7, 2026
@efekrskl efekrskl added http Issues and PRs related to the http subsystem. stream Issues and PRs related to Node.js streams. abortcontroller Issues and PRs related to the AbortController and AbortSignal APIs. labels Jul 7, 2026

@AugustinMauroy AugustinMauroy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in term of deprecation.md that super nice rest I'm not expert.

Comment thread doc/api/deprecations.md Outdated
@efekrskl
efekrskl force-pushed the doc/deprecate-signal-long-lived branch from 1c42e94 to d878b94 Compare August 21, 2026 18:13

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bjohansebas bjohansebas added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 22, 2026
Comment thread doc/api/child_process.md Outdated
@trivikr trivikr removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 22, 2026
@trivikr trivikr added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 23, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 75c1f6b into nodejs:main Aug 23, 2026
26 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 75c1f6b

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 23, 2026
aduh95 pushed a commit that referenced this pull request Aug 29, 2026
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64342
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

abortcontroller Issues and PRs related to the AbortController and AbortSignal APIs. author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation. http Issues and PRs related to the http subsystem. stream Issues and PRs related to Node.js streams.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate AbortSignal on resources that are not actions

7 participants