fs: preserve directory timestamps in cp by abhi128nandan · Pull Request #65540 · nodejs/node

abhi128nandan · 2026-08-25T11:42:57Z

fs: preserve directory timestamps in cp

This fixes an issue where fs.cp and fs.cpSync (when a filter is
provided) correctly restore mtime and atime on copied files when
preserveTimestamps: true is passed, but skip restoring them for
directories.

The fix applies the existing setDestTimestamps helper to directories,
ensuring it is called after directory creation/copying but before any
modes are restored (since restoring a read-only mode would prevent
timestamp modification).

Note: This fix covers fs.cp() (async, all cases) and fs.cpSync()
when a filter is provided. The native fast path used by cpSync()
without a filter (CpSyncCopyDir in src/node_file.cc) has the
identical gap and is left for a separate follow-up contribution, since
it requires native code changes and a different review path.

This fixes an issue where fs.cp and fs.cpSync (when a filter is provided) correctly restore mtime and atime on copied files when preserveTimestamps: true is passed, but skip restoring them for directories. The fix applies the existing setDestTimestamps helper to directories, ensuring it is called after directory creation/copying but before any modes are restored (since restoring a read-only mode would prevent timestamp modification). Note: This fix covers fs.cp() (async, all cases) and fs.cpSync() when a filter is provided. The native fast path used by cpSync() without a filter (CpSyncCopyDir in src/node_file.cc) has the identical gap and is left for a separate follow-up contribution, since it requires native code changes and a different review path. Signed-off-by: Abhinandan Kumar <abhi128618@gmail.com>

abhi128nandan · 2026-08-27T13:19:38Z

Could someone please check the result of Jenkins CI job 76579? I’m unable to access the job because Jenkins shows “abhi128nandan is missing the Overall/Read permission”, so I can’t see whether there’s an actual test failure or an infrastructure issue. Thanks!

sxa · 2026-08-27T13:35:45Z

Could someone please check the result of Jenkins CI job 76579? I’m unable to access the job because Jenkins shows “abhi128nandan is missing the Overall/Read permission”, so I can’t see whether there’s an actual test failure or an infrastructure issue. Thanks!

I woldn't normally see a request like this but I happened to be looking at the job (randomly) for something else so I'll reply. The jobs is still running. The message with the link was only posted 40 minutes ago and it takes longer than that to run through the tests.

nodejs-github-bot · 2026-08-27T19:33:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76600/

codecov · 2026-08-27T23:12:42Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.08%. Comparing base (2743045) to head (6661a99).
⚠️ Report is 34 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #65540      +/-   ##
==========================================
+ Coverage   90.06%   90.08%   +0.01%     
==========================================
  Files         751      751              
  Lines      254917   254926       +9     
  Branches    48133    48136       +3     
==========================================
+ Hits       229580   229638      +58     
+ Misses      16493    16463      -30     
+ Partials     8844     8825      -19

Files with missing lines	Coverage Δ
lib/internal/fs/cp/cp-sync.js	`70.56% <100.00%> (+7.29%)`	⬆️
lib/internal/fs/cp/cp.js	`89.02% <100.00%> (+0.16%)`	⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

abhi128nandan · 2026-08-28T19:34:47Z

Could a collaborator please approve/re-run the GitHub Actions and start Jenkins CI for the updated HEAD 6661a995? The previous CI run was fully green; I synced the branch with main, which resulted in the new HEAD.

LiviaMedeiros · 2026-08-28T22:01:55Z

Could a collaborator please approve/re-run the GitHub Actions and start Jenkins CI for the updated HEAD 6661a995? The previous CI run was fully green; I synced the branch with main, which resulted in the new HEAD.

Was there a reason to sync? AFAICT there were no conflicts with current main, it's completely fine to keep PR branch slightly 'outdated' as long as there's no recent changes on main that can't coexist with it.

nodejs-github-bot · 2026-08-29T11:57:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76686/

abhi128nandan · 2026-08-29T18:47:12Z

“I’m unable to inspect the Jenkins failure because Jenkins says I’m missing the Overall/Read permission. Could someone check the failing job logs?”

nodejs-github-bot · 2026-08-30T05:44:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76718/

abhi128nandan · 2026-08-30T18:44:46Z

The commit queue failed because my branch contains the 6661a99 merge commit from syncing main. The original PR commit itself was applied successfully. Should I rebase/drop the merge commit and push the updated branch?

jasnell · 2026-08-30T20:39:16Z

Drop the merge commit :-)

This fixes an issue where fs.cp and fs.cpSync (when a filter is provided) correctly restore mtime and atime on copied files when preserveTimestamps: true is passed, but skip restoring them for directories. The fix applies the existing setDestTimestamps helper to directories, ensuring it is called after directory creation/copying but before any modes are restored (since restoring a read-only mode would prevent timestamp modification). Note: This fix covers fs.cp() (async, all cases) and fs.cpSync() when a filter is provided. The native fast path used by cpSync() without a filter (CpSyncCopyDir in src/node_file.cc) has the identical gap and is left for a separate follow-up contribution, since it requires native code changes and a different review path. Signed-off-by: Abhinandan Kumar <abhi128618@gmail.com> PR-URL: #65540 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>

LiviaMedeiros · 2026-08-31T09:19:54Z

@abhi128nandan thank you!

Regarding the previous CI runs showing failures, it's caused by random flakes not related to this PR. Nothing to worry about.

https://ci.nodejs.org/job/node-test-pull-request/76600/ is green and it's based on 321146b9bf8ad909304aeb24872be4723bf25ea1 commit so this can be landed.

LiviaMedeiros · 2026-08-31T09:20:17Z

Landed in 8fe4b64

This completes the work started in PR nodejs#65540. While the previous PR fixed directory timestamp preservation for the JavaScript paths, the native C++ fast path (CpSyncCopyDir in src/node_file.cc) used by fs.cpSync when no filter is provided still failed to preserve directory timestamps. This commit invokes the existing CopyUtimes helper for both the root destination directory and all subdirectories after their contents are recursively copied. PR-URL: nodejs#65678 Signed-off-by: Abhinandan Kumar <abhi128618@gmail.com>

This completes the work started in PR nodejs#65540. The previous PR fixed directory timestamp preservation for the JavaScript paths, but the native C++ fast path (CpSyncCopyDir in src/node_file.cc) used by fs.cpSync when no filter is provided still failed to preserve directory timestamps. This commit invokes the existing CopyUtimes helper for both the root destination directory and all subdirectories after their contents are recursively copied, aligning the native behavior with the JavaScript fallback. PR-URL: nodejs#65678 Signed-off-by: Abhinandan Kumar <abhi128618@gmail.com>

nodejs-github-bot added fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Aug 25, 2026

abhi128nandan force-pushed the fix-cp-directory-timestamps branch from 70b223c to 321146b Compare August 25, 2026 11:46

jasnell reviewed Aug 25, 2026

View reviewed changes

Comment thread lib/internal/fs/cp/cp-sync.js

jasnell approved these changes Aug 25, 2026

View reviewed changes

LiviaMedeiros approved these changes Aug 27, 2026

View reviewed changes

LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2026

This comment was marked as outdated.

Sign in to view

LiviaMedeiros approved these changes Aug 28, 2026

View reviewed changes

LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 28, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 28, 2026

This comment was marked as outdated.

Sign in to view

panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 29, 2026

LiviaMedeiros added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 30, 2026

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 30, 2026

This comment was marked as outdated.

Sign in to view

abhi128nandan force-pushed the fix-cp-directory-timestamps branch from 6661a99 to 321146b Compare August 30, 2026 20:55

LiviaMedeiros closed this Aug 31, 2026

LiviaMedeiros removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Aug 31, 2026

abhi128nandan mentioned this pull request Aug 31, 2026

fs: preserve directory timestamps in cpSync fast path #65678

Open

Uh oh!

Uh oh!

Conversation

abhi128nandan commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

abhi128nandan commented Aug 27, 2026

Uh oh!

sxa commented Aug 27, 2026

Uh oh!

nodejs-github-bot commented Aug 27, 2026

Uh oh!

codecov Bot commented Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

abhi128nandan commented Aug 28, 2026

Uh oh!

LiviaMedeiros commented Aug 28, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Aug 29, 2026

Uh oh!

abhi128nandan commented Aug 29, 2026

Uh oh!

nodejs-github-bot commented Aug 30, 2026

Uh oh!

This comment was marked as outdated.

abhi128nandan commented Aug 30, 2026

Uh oh!

jasnell commented Aug 30, 2026

Uh oh!

LiviaMedeiros commented Aug 31, 2026

Uh oh!

LiviaMedeiros commented Aug 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

abhi128nandan commented Aug 25, 2026 •

edited

Loading

codecov Bot commented Aug 27, 2026 •

edited

Loading