Skip to content

quic: stop guarding ngtcp2_recv_stop_sending callback field - #65688

Open
Renegade334 wants to merge 2 commits into
nodejs:mainfrom
Renegade334:quic-no-guard-required-callbacks
Open

quic: stop guarding ngtcp2_recv_stop_sending callback field#65688
Renegade334 wants to merge 2 commits into
nodejs:mainfrom
Renegade334:quic-no-guard-required-callbacks

Conversation

@Renegade334

@Renegade334 Renegade334 commented Aug 31, 2026

Copy link
Copy Markdown
Member

When we updated ngtcp2 to v1.25, a version guard was added to the recv_stop_sending field of our ngtcp2 callbacks structs. At the time, we didn't implement it and we just passed nullptr, so it wasn't necessary to break existing shared builds over it.

Now that we have migrated to using this callback, and session functionality depends on it, we shouldn't be allowing older shared builds to omit it.

Drive-by: label the remaining omitted callbacks for ease of maintenance.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC transport implementation. labels Aug 31, 2026
@Renegade334
Renegade334 force-pushed the quic-no-guard-required-callbacks branch 2 times, most recently from 5415548 to a45f46c Compare August 31, 2026 16:32
@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.07%. Comparing base (705646f) to head (69c69b0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65688      +/-   ##
==========================================
- Coverage   90.07%   90.07%   -0.01%     
==========================================
  Files         754      754              
  Lines      256395   256395              
  Branches    48499    48507       +8     
==========================================
- Hits       230937   230935       -2     
- Misses      16569    16570       +1     
- Partials     8889     8890       +1     

see 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Renegade334
Renegade334 force-pushed the quic-no-guard-required-callbacks branch from a45f46c to 69c69b0 Compare August 31, 2026 18:56
@Renegade334 Renegade334 changed the title quic: stop guarding ngtcp2_stream_close2 callback field quic: stop guarding ngtcp2_recv_stop_sending callback field Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC transport implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants