fs: handle recursive watch setup races - #65699
Open
panva wants to merge 2 commits into
Open
Conversation
nodejs-github-bot
added
fs
panva
force-pushed
the
fix-recursive-watch-aix-enodev
branch
from
September 1, 2026 08:39
668c4de to
bdb25e9
Compare
panva
marked this pull request as draft
September 1, 2026 08:56
Contributor
Arm directory watchers before reading entries to close the setup window. Discard stale watcher state when paths disappear so recreated paths can be watched again. On AIX, treat ENODEV as missing only when stat confirms the path is gone. Preserve root throwIfNoEntry behavior and other watch errors. Fixes: nodejs#65697 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
panva
force-pushed
the
fix-recursive-watch-aix-enodev
branch
from
September 1, 2026 10:05
bdb25e9 to
67b5c41
Compare
panva
marked this pull request as ready for review
September 1, 2026 10:10
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65699 +/- ##
==========================================
- Coverage 90.07% 90.06% -0.02%
==========================================
Files 754 754
Lines 256395 256444 +49
Branches 48494 48516 +22
==========================================
+ Hits 230947 230963 +16
- Misses 16563 16582 +19
- Partials 8885 8899 +14
🚀 New features to boost your workflow:
|
Collaborator
codebytere
approved these changes
Sep 1, 2026
panva
added
the
author ready
lpinca
reviewed
Sep 1, 2026
panva
removed
the
author ready
Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arm directory watchers before reading entries to close the setup window. Discard stale watcher state when paths disappear so recreated paths can be watched again.
On AIX, treat ENODEV as missing only when stat confirms the path is gone. Preserve root throwIfNoEntry behavior and other watch errors.
Fixes: #65697