Skip to content

v8,lib: remove --no-js-regexp-escape runtime flag - #65703

Closed
aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:regexp-escape
Closed

v8,lib: remove --no-js-regexp-escape runtime flag#65703
aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:regexp-escape

Conversation

@aduh95

@aduh95 aduh95 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

v8/v8@e11c1ad removed the flag upstream

o- and others added 2 commits September 1, 2026 12:08
@o- @aduh95
deps: V8: backport e11c1ad83914
a14ab3e 
Original commit message:

    [cleanup] Remove --js-regexp-escape

    Remove the --js-regexp-escape flag and install RegExp.escape
    unconditionally into the baseline snapshot. RegExp.escape has been
    enabled by default since M136.

    Bug: 548385945
    TAG=agy
    CONV=052f499d-4ee5-4a10-8afd-900ba4a338db

    Change-Id: I8d820f28dc061d0e338ecf196c34f919c9c3f223
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8267346
    Auto-Submit: Olivier Flückiger <olivf@chromium.org>
    Reviewed-by: Nikolaos Papaspyrou <nikolaos@chromium.org>
    Commit-Queue: Olivier Flückiger <olivf@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#109360}

Refs: v8/v8@e11c1ad
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95
util: use RegExpEscape instead of custom escaping
d1698cb 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Sep 1, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Sep 1, 2026
@aduh95 aduh95 closed this Sep 1, 2026
@aduh95
aduh95 deleted the regexp-escape branch September 1, 2026 12:15
@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.05%. Comparing base (f9ab994) to head (d1698cb).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #65703      +/-   ##
==========================================
- Coverage   90.07%   90.05%   -0.02%     
==========================================
  Files         754      754              
  Lines      256395   256392       -3     
  Branches    48494    48500       +6     
==========================================
- Hits       230947   230897      -50     
- Misses      16563    16618      +55     
+ Partials     8885     8877       -8
Files with missing lines Coverage Δ
lib/internal/util/debuglog.js 95.30% <100.00%> (-0.03%) ⬇️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aduh95 @nodejs-github-bot @o-