Skip to content

test: deflake test-runner-coverage #65728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christianaurichzm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: deflake test-runner-coverage #65728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions test/parallel/parallel.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ test-fs-read-stream-concurrent-reads: PASS, FLAKY
test-snapshot-incompatible: SKIP

[$system==win32]
# https://github.com/nodejs/node/issues/55154#issuecomment-5423571475
test-runner-coverage: PASS, FLAKY
# https://github.com/nodejs/node/issues/59090
test-inspector-network-fetch: PASS, FLAKY
# https://github.com/nodejs/node/issues/59636
Expand All @@ -38,8 +36,6 @@ test-performance-function: PASS, FLAKY
test-esm-loader-hooks-inspect-wait: PASS, FLAKY

[$system==linux && $arch==s390x]
# https://github.com/nodejs/node/issues/55154#issuecomment-5423571475
test-runner-coverage: PASS, FLAKY
# https://github.com/nodejs/node/issues/58353
test-http2-debug: PASS, FLAKY

Expand Down Expand Up @@ -101,8 +97,6 @@ test-fs-watch-ignore-mixed: SKIP
test-fs-watch-ignore-regexp: SKIP

[$system==aix]
# https://github.com/nodejs/node/issues/55154#issuecomment-5423571475
test-runner-coverage: PASS, FLAKY
# https://github.com/nodejs/node/issues/54346
test-esm-loader-hooks-inspect-wait: PASS, FLAKY
# https://github.com/nodejs/node/issues/65697
Expand Down
4 changes: 4 additions & 0 deletions test/parallel/test-runner-coverage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ test('test coverage report', async (t) => {

test('test tap coverage reporter', skipIfNoInspector, async (t) => {
await t.test('coverage is reported and dumped to NODE_V8_COVERAGE if present', (t) => {
// A dump left here would match the negative checks below on pid reuse.
t.after(() => tmpdir.refresh());
const fixture = fixtures.path('test-runner', 'coverage.js');
const args = [
'--experimental-test-coverage',
Expand Down Expand Up @@ -154,6 +156,8 @@ test('test tap coverage reporter', skipIfNoInspector, async (t) => {

test('test spec coverage reporter', skipIfNoInspector, async (t) => {
await t.test('coverage is reported and dumped to NODE_V8_COVERAGE if present', (t) => {
// A dump left here would match the negative checks below on pid reuse.
t.after(() => tmpdir.refresh());
const fixture = fixtures.path('test-runner', 'coverage.js');
const args = [
'--experimental-test-coverage',
Expand Down
Loading