deps,lib,tools: remove jitless and lite modes - #66459
Open
ShogunPanda wants to merge 4 commits into
Open
ShogunPanda wants to merge 4 commits into
ShogunPanda wants to merge 4 commits into
Conversation
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
Collaborator
|
Review requested:
|
anonrig
approved these changes
Oct 2, 2026
ronag
approved these changes
Oct 2, 2026
Renegade334
reviewed
Oct 2, 2026
Member
There was a problem hiding this comment.
These are going to require perpetual V8 floating patches, are they strictly necessary? eg. can we override --no-jitless in InitializeNodeWithArgsInternal?
Contributor
Author
There was a problem hiding this comment.
Done. How about now?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66459 +/- ##
==========================================
- Coverage 90.43% 90.42% -0.02%
==========================================
Files 791 790 -1
Lines 275604 275427 -177
Branches 52849 52812 -37
==========================================
- Hits 249239 249045 -194
- Misses 16770 16784 +14
- Partials 9595 9598 +3
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove support for jitless execution and V8 lite mode. Built-in functionality, including
fetch()through Undici and TypeScript through Amaro, requires WebAssembly; supporting configurations without it leaves Node.js partially functional.Changes
NODE_OPTIONS, and V8’s runtime flag API.--v8-lite-modebuild support, always enable WebAssembly, and reject interpreter-only V8 build defines.ERR_WEBASSEMBLY_NOT_SUPPORTED.Notes
Assisted-By: OpenAI:GPT-6 Astra Ultrafast <openai/gpt-6-astra-ultrafast>