Conversation
Skip the V8 and OpenSSL vendored trees when checking out sources for lint-cpp. Keep other paths included so new directories are checked out by default. Assisted-by: Codex Signed-off-by: inoway46 <inoueyuya416@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
inoway46
commented
Oct 3, 2026
Comment on lines
+47
to
+48
| !/deps/openssl/ | ||
| !/deps/v8/ |
Contributor
Author
There was a problem hiding this comment.
A checkout limited to the directories needed by lint-cpp would retain about 103 MB and exclude 600 MB:
| Exclusion candidate | Size (uncompressed) |
|---|---|
deps/openssl/ |
241.9 MB |
deps/v8/ |
191.8 MB |
deps/icu-small/ |
33.2 MB |
deps/crates/ |
25.7 MB |
deps/LIEF/ |
16.9 MB |
deps/npm/ |
14.8 MB |
deps/perfetto/ |
11.3 MB |
deps/simdjson/ |
10.5 MB |
deps/sqlite/ |
10.2 MB |
deps/ngtcp2/ |
6.4 MB |
| Other files | 37.5 MB |
| Total | 600.3 MB |
This PR excludes only V8 and OpenSSL: 434 MB, or 72% of the potential reduction. Keeping the list short reduces maintenance risk: if an excluded directory later becomes a lint input, Makefile's wildcard could silently skip it.
inoway46
marked this pull request as ready for review
October 3, 2026 04:11
panva
approved these changes
Oct 3, 2026
aduh95
approved these changes
Oct 3, 2026
aduh95
added
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude
deps/v8/anddeps/openssl/from thelint-cppcheckout, keeping other paths included by default. They account for 62% of tracked file size (434/704 MB, uncompressed). Both checkout strategies select the same 579 lint targets.In 128 trials per variant on the same commit, average checkout time fell from 28.59s to 20.85s.
ubuntu-slim(before)ubuntu-slim(after)Benchmark:
full= before,sparse= after.Refs: #64972 (comment)