feat: add Vite+ installation method - #9182
liangmiQwQ wants to merge 7 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9182 +/- ##
==========================================
+ Coverage 86.06% 86.15% +0.08%
==========================================
Files 86 86
Lines 6041 6051 +10
Branches 358 357 -1
==========================================
+ Hits 5199 5213 +14
+ Misses 838 834 -4
Partials 4 4 ☔ View full report in Codecov by Harness. |
📦 Build Size ComparisonSummary
Changes🔄 Modified Routes (4)
|
|
CI failings seem not caused by this PR |
|
cc @TheAlexLichter can someone from Vite+ sign off on this change and confirm that the logo + installation steps match official documents? |
|
FYI I'm also a team member of Vite+. I'll call other team members to review the PR. |
|
Oh! Now embarrassing of me! I saw you weren't a member of the @voidzero-dev org and didn't look into it further. |
jong-kyung
left a comment
There was a problem hiding this comment.
LGTM! The Vite+ installation steps look good to me.
As a member of the Vite+ team, I'm really happy to see Vite+ added as an option for installing Node.js.
|
TIL Vite+ could install Node.js |
Wholesome! |
|
Thank you @liangmiQwQ 🙌🏻 |
Description
This PR adds Vite+ as a community method to install Node.js.
Vite+ is the unified toolchain and entry point for web development. It includes Node.js and package manager features via
vp env. It satisfied all the requirement as a community installation methodv17.0.0+)Win/mac/linux)Validation
I've tested on my mac and ensured it works. I didn't add a separate test considering this is essentially just an update to the metadata; the generic part basically remains unchanged.
Related Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.